Skip to content

contactcenterinsights: add list resources - #18781

Open
BBBmau wants to merge 3 commits into
GoogleCloudPlatform:mainfrom
BBBmau:add-contactcenterinsights-list-resources
Open

contactcenterinsights: add list resources#18781
BBBmau wants to merge 3 commits into
GoogleCloudPlatform:mainfrom
BBBmau:add-contactcenterinsights-list-resources

Conversation

@BBBmau

@BBBmau BBBmau commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator

Adds list-resource generation for the following contactcenterinsights resources:

  • google_contact_center_insights_analysis_rule
  • google_contact_center_insights_assessment_rule
  • google_contact_center_insights_auto_labeling_rule
  • google_contact_center_insights_qa_scorecard
  • google_contact_center_insights_view

query_test_file.go.tmpl now imports strings (with _ = strings.Trim, same pattern as the regular sample test file) so list-query tests compile when the first sample uses strings.* in test_vars_overrides.

Left out:

  • EncryptionSpec — location singleton, no list collection
  • QaScorecardRevision / QaQuestion — list URLs have unsupported parent scope params
`google_contact_center_insights_analysis_rule`
`google_contact_center_insights_assessment_rule`
`google_contact_center_insights_auto_labeling_rule`
`google_contact_center_insights_qa_scorecard`
`google_contact_center_insights_view`

@modular-magician

modular-magician commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit cb3bd03:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 15 files changed, 1677 insertions(+)
google-beta provider View Diff 15 files changed, 1677 insertions(+)

Step 1: Replaying Mode

Caution

Build Failure during VCR tests

🔴 REPLAYING mode: The following packages failed to build:

  • contactcenterinsights

Please fix the compilation errors to complete your PR.

View the build log

@BBBmau VCR tests complete for cb3bd03!

Query-test generation emits strings.ToLower from sample test_vars_overrides without importing strings.
@modular-magician

modular-magician commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit a8eef6b:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 9 files changed, 1004 insertions(+)
google-beta provider View Diff 9 files changed, 1004 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
23 19 1 3
Affected Service Packages
  • contactcenterinsights

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccContactCenterInsightsAnalysisRuleListQuery_generated
  • TestAccContactCenterInsightsQaScorecardListQuery_generated
  • TestAccContactCenterInsightsViewListQuery_generated

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccContactCenterInsightsAnalysisRuleListQuery_generated
✅ Log TestAccContactCenterInsightsQaScorecardListQuery_generated
✅ Log TestAccContactCenterInsightsViewListQuery_generated

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@BBBmau VCR tests complete for a8eef6b!

…s import

Query tests copy test_vars_overrides into generated Go, so samples using strings.ToLower failed to compile. Import strings the same way the regular sample test template does.
@modular-magician

modular-magician commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit b260401:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 86 files changed, 1829 insertions(+)
google-beta provider View Diff 89 files changed, 1835 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
2415 2242 167 6
Affected Service Packages
  • storage
  • compute
  • discoveryengine
  • networkservices
  • pubsub
  • bigquery
  • cloudrun
  • cloudscheduler
  • contactcenterinsights
  • migrationcenter
  • secretmanager
  • sql

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccComputeInstanceFromMachineImage_diffProject
  • TestAccComputeSecurityPolicy_withPreconfiguredWafConfig
  • TestAccContactCenterInsightsAssessmentRuleListQuery_generated
  • TestAccContactCenterInsightsAutoLabelingRuleListQuery_generated
  • TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
  • TestAccPubsubSubscription_pubsubSubscriptionTagsExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccContactCenterInsightsAssessmentRuleListQuery_generated
✅ Log TestAccContactCenterInsightsAutoLabelingRuleListQuery_generated
❌ Error · Log - TestAccComputeInstanceFromMachineImage_diffProject
❌ Error · Log - TestAccComputeSecurityPolicy_withPreconfiguredWafConfig
❌ Error · Log - TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
❌ Error · Log - TestAccPubsubSubscription_pubsubSubscriptionTagsExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@BBBmau VCR tests complete for b260401!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants