feat(chronicle): add google_chronicle_data_table_rows resource - #18778
Open
DrainBamage33 wants to merge 1 commit into
Open
feat(chronicle): add google_chronicle_data_table_rows resource#18778DrainBamage33 wants to merge 1 commit into
DrainBamage33 wants to merge 1 commit into
Conversation
* Add google_chronicle_data_table_rows resource definition and custom templates * Support bulk operations (:bulkReplace) with TypeSet and custom hash function * Add acceptance tests and basic example
modular-magician
added
the
awaiting-approval
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Author
|
@rileykarson can you please review this change? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the
google_chronicle_data_table_rowsresource to manage all rows in a Chronicle Data Table in bulk using the:bulkReplaceAPI.Changes
mmv1/products/chronicle/DataTableRows.yaml.BulkReplaceDataTableRowsRequest.GET .../dataTableRowsresponses.is_set: truewithresourceChronicleDataTableRowHashto eliminate spurious drift caused by non-deterministic Spanner storage row order.Test Results
=== RUN TestAccChronicleDataTableRows_chronicleDataTableRowsBasicExample --- PASS: TestAccChronicleDataTableRows_chronicleDataTableRowsBasicExample (31.86s) === RUN TestAccChronicleDataTableRows_update --- PASS: TestAccChronicleDataTableRows_update (41.67s) PASS
Related Issue
Fixes hashicorp/terraform-provider-google#29019
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.