Skip to content

bigtable: fix TestAccBigtableTable_familyType immutable-field ExpectError regex - #18760

Open
SirGitsalot wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
SirGitsalot:fix-bigtable-table-familytype
Open

bigtable: fix TestAccBigtableTable_familyType immutable-field ExpectError regex#18760
SirGitsalot wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
SirGitsalot:fix-bigtable-table-familytype

Conversation

@SirGitsalot

Copy link
Copy Markdown
Member

Fixes nightly acceptance test failure for TestAccBigtableTable_familyType.

Root Cause & Fix

When the test attempts to change a column family's aggregate type (intmax -> intmin), the Bigtable API rejects the modification and returns an error indicating immutable fields. Previously, the error message only listed a single field:
Immutable fields 'value_type.aggregate_type' cannot be updated.

The API can now include additional immutable fields in the message (e.g., Immutable fields 'value_type.aggregate_type,sql_type' cannot be updated.).

This fix loosens the ExpectError regex in mmv1/third_party/terraform/services/bigtable/resource_bigtable_table_test.go to tolerate additional fields while continuing to verify that value_type.aggregate_type is reported as immutable.

@modular-magician

modular-magician commented Aug 22, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit c3c0ce5:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 1 insertion(+), 1 deletion(-)
google-beta provider View Diff 1 file changed, 1 insertion(+), 1 deletion(-)

Test report

Analytics

Total Tests Passed Skipped Affected
67 0 67 0
Affected Service Packages
  • bigtable

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@SirGitsalot, @annguy3n VCR tests complete for c3c0ce5!

@SirGitsalot
SirGitsalot marked this pull request as ready for review August 25, 2026 19:11
@SirGitsalot

Copy link
Copy Markdown
Member Author

@modular-magician reassign-reviewer

@github-actions

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions
github-actions Bot requested a review from ScottSuarez August 25, 2026 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants