ces: add language_code_variable to remote_dialogflow_agent - #18759
Conversation
|
@modular-magician reassign-reviewer |
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit a3f9a0c: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
🟢 All tests passed! View the recording VCR build log or the debug logs folder for detailed results. @slevenick, @rileykarson, @ScottSuarez VCR tests complete for a3f9a0c! |
|
@rileykarson This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
| the Dialogflow session. If unspecified, the default language code of the | ||
| Dialogflow agent will be used. |
| the Dialogflow session. If unspecified, the default language code of the | ||
| Dialogflow agent will be used. |
There was a problem hiding this comment.
VCR won't catch a default value, how have we checked for one?
There was a problem hiding this comment.
Ran TestAccCESAgent_cesAgentRemoteDialogflowAgentInterruptionExample, logs in b/550544198. This field doesn't come back if not set
a3f9a0c to
08dc465
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 08dc465: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode 🟢 All tests passed in Replaying mode! No Recording was needed. View the replaying VCR build log @slevenick VCR tests complete for 08dc465! |
641f633
Add support for
remote_dialogflow_agent.language_code_variableingoogle_ces_agent.