Skip to content

ces: add language_code_variable to remote_dialogflow_agent - #18759

Merged
slevenick merged 1 commit into
GoogleCloudPlatform:mainfrom
slevenick:mm-b-550544198
Aug 26, 2026
Merged

ces: add language_code_variable to remote_dialogflow_agent#18759
slevenick merged 1 commit into
GoogleCloudPlatform:mainfrom
slevenick:mm-b-550544198

Conversation

@slevenick

Copy link
Copy Markdown
Contributor

Add support for remote_dialogflow_agent.language_code_variable in google_ces_agent.

ces: added `language_code_variable` field to `google_ces_agent` resource

@slevenick

Copy link
Copy Markdown
Contributor Author

@modular-magician reassign-reviewer

@github-actions

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician

modular-magician commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit a3f9a0c:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 8 files changed, 55 insertions(+)
google-beta provider View Diff 8 files changed, 55 insertions(+)
terraform-google-conversion View Diff 1 file changed, 11 insertions(+)
Open in Cloud Shell View Diff 1 file changed, 1 insertion(+)

Test report

Analytics

Total Tests Passed Skipped Affected
75 73 0 2
Affected Service Packages
  • ces

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccCESAgent_cesAgentRemoteDialogflowAgentExample
  • TestAccCESAgent_cesAgentRemoteDialogflowAgentExample_update

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccCESAgent_cesAgentRemoteDialogflowAgentExample
✅ Log TestAccCESAgent_cesAgentRemoteDialogflowAgentExample_update

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@slevenick, @rileykarson, @ScottSuarez VCR tests complete for a3f9a0c!

@slevenick
slevenick removed the request for review from ScottSuarez August 22, 2026 00:06
@github-actions

Copy link
Copy Markdown

@rileykarson This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Comment thread mmv1/products/ces/AppVersion.yaml Outdated
Comment on lines +368 to +369
the Dialogflow session. If unspecified, the default language code of the
Dialogflow agent will be used.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

output, fix description

Comment on lines +320 to +321
the Dialogflow session. If unspecified, the default language code of the
Dialogflow agent will be used.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VCR won't catch a default value, how have we checked for one?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran TestAccCESAgent_cesAgentRemoteDialogflowAgentInterruptionExample, logs in b/550544198. This field doesn't come back if not set

@modular-magician

modular-magician commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 08dc465:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 8 files changed, 53 insertions(+)
google-beta provider View Diff 8 files changed, 53 insertions(+)
terraform-google-conversion View Diff 1 file changed, 11 insertions(+)
Open in Cloud Shell View Diff 1 file changed, 1 insertion(+)

Test report

Analytics

Total Tests Passed Skipped Affected
79 79 0 0
Affected Service Packages
  • ces

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@slevenick VCR tests complete for 08dc465!

@slevenick
slevenick added this pull request to the merge queue Aug 26, 2026
Merged via the queue into GoogleCloudPlatform:main with commit 641f633 Aug 26, 2026
24 of 26 checks passed
@slevenick
slevenick deleted the mm-b-550544198 branch August 26, 2026 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants