appengine: keep auth_domain as hashicorptest.com in TestAccAppEngineApplication_basic update

[SirGitsalot]

Fixes nightly acceptance test failure for TestAccAppEngineApplication_basic.

Root Cause & Fix

In TestAccAppEngineApplication_basic, the update step previously changed auth_domain from "hashicorptest.com" to "tf-test.club". Updating auth_domain triggers an invalid update request in test environments.

This change keeps auth_domain set to "hashicorptest.com" in the update step in mmv1/third_party/terraform/services/appengine/resource_app_engine_application_test.go.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit a46af4b:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
google provider	View Diff	1 file changed, 24 insertions(+), 2 deletions(-)
google-beta provider	View Diff	1 file changed, 24 insertions(+), 2 deletions(-)

Test report

Analytics

Total Tests	Passed	Skipped	Affected
16	12	3	1

Affected Service Packages

• appengine

Learn how VCR tests work

---

Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests

• TestAccAppEngineApplication_basic

View the replaying VCR build log

---

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
❌ Error · Log	-	TestAccAppEngineApplication_basic

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@SirGitsalot VCR tests complete for a46af4b!

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit b391b21:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
google provider	View Diff	1 file changed, 1 insertion(+), 1 deletion(-)
google-beta provider	View Diff	1 file changed, 1 insertion(+), 1 deletion(-)

Test report

Analytics

Total Tests	Passed	Skipped	Affected
16	12	3	1

Affected Service Packages

• appengine

Learn how VCR tests work

---

Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests

• TestAccAppEngineApplication_basic

View the replaying VCR build log

---

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
✅ Log	✅	TestAccAppEngineApplication_basic

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@SirGitsalot VCR tests complete for b391b21!

[SirGitsalot]

@modular-magician reassign-reviewer

[github-actions]

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[roaks3]

I think this implies that the field should be changed to force new?

[SirGitsalot]

I think this implies that the field should be changed to force new?

AFAICT the field is still mutable, but there's now a check that domain is a valid Google Workspace domain. "hashicorptest.com" is such a domain so the creation succeeds. "tf-test.club" is not such domain, but used to work for the update step before the check was added.