accesscontextmanager: serialize user access binding tests in TestAccAccessContextManager - #18749
Conversation
…ccessContextManager
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 29886f1: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode 🟢 All tests passed in Replaying mode! No Recording was needed. View the replaying VCR build log @SirGitsalot VCR tests complete for 29886f1! |
|
@modular-magician reassign-reviewer |
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Fixes nightly acceptance test failure for
TestAccAccessContextManager.Root Cause & Fix
The
TestAccAccessContextManager/gcp_user_access_bindingandTestAccAccessContextManager/gcp_user_access_binding_principalsubtests were previously annotated witht.Parallel(). Because only a single Access Policy can exist per organization in Access Context Manager, running these tests concurrently caused intermittent409 Conflict: Policy already exists with parent organizations/...errors.This fix removes
t.Parallel()from both subtests inmmv1/third_party/terraform/services/accesscontextmanager/resource_access_context_manager_gcp_user_access_binding_test.goso they execute serially within the sharedTestAccAccessContextManagertest runner.