feat: Add google_serviceusagev2_consumer_policy resource by shahmedhaCorp · Pull Request #18735 · GoogleCloudPlatform/magic-modules

shahmedhaCorp · 2026-08-20T20:11:33Z

Adding new resource for service usage v2 consumer policy

b/543553096

Previous PR: #18517

Release Note Template for Downstream PRs (will be copied)

serviceusagev2: added `google_service_usage_v2_consumer_policy` resource

github-actions · 2026-08-20T20:13:59Z

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

github-actions · 2026-08-25T09:50:49Z

@melinath This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

melinath

This is mostly just copying over the existing comments from the previous PR - I need to think about your responses there some more but there are also a couple unaddressed comments remaining

melinath · 2026-08-26T18:58:38Z

+// check dependencies if the "respect_dependencies" flag is enabled
+validateDependenciesEnabled := d.Get("validate_dependencies").(bool)
+
+if validateDependenciesEnabled {


From #18517 (comment):

👍 okay! makes sense. Just to double-check, do we need this to also run this on pre_create and pre_delete, since those are both technically also updates?

melinath · 2026-08-26T18:59:20Z

+    description: |
+      (Optional) Default value is true. If true, this flag enforces dependency management within the consumer policy. When adding a new service, it verifies that all its dependencies are already present/added in the policy. Conversely, when removing a service, it ensures that no other services within the policy depend on the service to be removed. If the validation fails, a comprehensive message will be presented, outlining the missing dependencies and providing instructions on how to address the issue.
+    default_value: true
+  - name: 'check_usage_on_remove'


From #18517 (comment):

you're right; this doesn't make sense as a deletion_policy.

I find the name a little confusing; I had previously assumed that this was related to removing the resource, which is why I thought deletion_policy would make sense.

Is there a different name we could use? For example, force or ignore_validation_errors or similar? (I'd lean towards force since that's what the API flag is called.)

Also, does this need to be checked on create / delete, since those are both technically update calls?

melinath · 2026-08-26T18:59:40Z

+//
+// ----------------------------------------------------------------------------
+
+package serviceusagev2


Why does the operation need to be handwritten? It would be great to avoid this if possible.

The handwritten operation (service_usage_v2_operation.go.tmpl) is necessary because this resource requires bespoke client-side verification phases and custom error handling that standard declarative OpAsync cannot accommodate.

According to the technical design (go/terraform-suv2), before and during updates, the provider must run manual Client-Side Consistency Checks, Dependency Verification (using custom traversals from ListDescendantServices), and Usage Enforcements.

These custom pre-update and post-update Go template hooks rely explicitly on custom polling/waiting utility functions (like ServiceUsageV2OperationWaitTime). If we discard this handwritten file in favor of standard declarative generation, those custom template hooks can no longer access these custom standalone polling methods, leading to undefined compiler panics and breaking the entire build and test pipelines.

I tried switching to generating the operation code (by removing this file and adding autogen_async: true to ConsumerPolicy.yaml) and I don't see any compilation errors; ServiceUsageV2OperationWaitTime is present as expected.

The custom code here seems to be the error handling - but ServiceUsageV2OperationWaitTime already returns its error, and there aren't any retries or anything within the "wait" logic. See operation_generated.diff.txt

Could the error handling just happen one layer up in the pre_update hook? For create you can use custom_code.post_create_failure to handle the error; for update I think you should be able to use custom_code.post_update.

If this behavior is specific to this resource, that would be the best path; if you want this behavior to be consistent for every resource in the v2 service, then custom operation could make sense.

…lock

shahmedhaCorp · 2026-08-26T20:30:03Z

The TeamCity Services Diff Check / teamcity-services-diff-check (pull_request) is failing due to Provider codebase is missing services present in the TeamCity service file: [mlengine notebooks] which is not related to change in this PR.

modular-magician · 2026-08-26T20:31:23Z

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 318c5ed:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
`google` provider	View Diff	2 files changed, 130 insertions(+)
`google-beta` provider	View Diff	12 files changed, 1499 insertions(+)
`terraform-google-conversion`	View Diff	1 file changed, 282 insertions(+)

Missing service labels

The following new resources do not have corresponding service labels:

google_service_usage_v2_consumer_policy

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

Test report

Analytics

Total Tests	Passed	Skipped	Affected
6918	6207	692	19

Affected Service Packages

All service packages are affected

Learn how VCR tests work

Step 1: Replaying Mode

Action taken

Found 19 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests

TestAccBigqueryAnalyticsHubListingSubscription_bigqueryAnalyticshubListingSubscriptionPubsubExample
TestAccBigqueryAnalyticsHubListingSubscription_pubsub_allFields
TestAccBigqueryAnalyticsHubListingSubscription_pubsub_linked_resources
TestAccCloudRunV2WorkerPool_cloudrunv2WorkerPoolFullUpdate
TestAccComputeInstanceFromMachineImage_diffProject
TestAccComputeSecurityPolicy_withPreconfiguredWafConfig
TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
TestAccHypercomputeclusterCluster_inPlaceUpdates
TestAccHypercomputeclusterCluster_new
TestAccHypercomputeclusterCluster_update
TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
TestAccNetworkManagementNetworkMonitoringProvider__basic
TestAccNetworkManagementNetworkMonitoringProvider__deletion_policy
TestAccOracleDatabaseDbServers_basic
TestAccPubsubSubscription_pubsubSubscriptionTagsExample
TestAccServiceUsageV2ConsumerPolicy_update
TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_featureRegistry_updated
TestAccVertexAISemanticGovernancePolicyEngine_basic

View the replaying VCR build log

Step 2: Recording Mode

Caution

Panic occurred during VCR tests

🔴 RECORDING mode: The provider crashed with a panic. Please check the build log for details.

Please fix the issue to complete your PR.

View the build log

@shahmedhaCorp, @melinath VCR tests complete for 318c5ed!

melinath · 2026-08-26T23:34:29Z

The TeamCity Services Diff Check / teamcity-services-diff-check (pull_request) is failing due to Provider codebase is missing services present in the TeamCity service file: [mlengine notebooks] which is not related to change in this PR.

yeah, those were removed in the 8.0.0 major release, but it looks like we missed removing them from the main branch. It's not related to this PR.

#18774 will fix this.

github-actions Bot requested a review from c2thorn August 20, 2026 20:13

This comment was marked as outdated.

Sign in to view

github-actions Bot requested review from melinath and removed request for c2thorn August 20, 2026 21:18

This comment was marked as outdated.

Sign in to view

melinath reviewed Aug 26, 2026

View reviewed changes

mworonowicz and others added 9 commits August 26, 2026 19:20

Feat: add google_service_usage_v2_consumer_policy resource

6a0ac18

Remove handwritten operation template in favor of declarative async b…

db8e8f7

…lock

WIP: save progress on ConsumerPolicy

a45f943

Reinstate handwritten operation template from PR 18517

99e5fa3

Revert extraneous TeamCity configuration changes

36e6d94

Register serviceusagev2 in TeamCity configuration

f1aac70

Register serviceusagev2 in TeamCity configuration

a6b60ed

Revert extraneous TeamCity configuration changes

74fe44e

Register serviceusagev2 in TeamCity

bbb69ea

shahmedhaCorp force-pushed the feature-enhancement branch from f294dc6 to bbb69ea Compare August 26, 2026 19:36

github-actions Bot requested a review from melinath August 26, 2026 19:39

This comment was marked as outdated.

Sign in to view

Update enable_rules property to Array of NestedObjects

4841f35

This comment was marked as outdated.

Sign in to view

Register serviceusagev2 for TeamCity Diff Check

318c5ed

Uh oh!

Conversation

shahmedhaCorp commented Aug 20, 2026 • edited by melinath Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

github-actions Bot commented Aug 25, 2026

Uh oh!

melinath left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

melinath Aug 26, 2026

Choose a reason for hiding this comment

Uh oh!

melinath Aug 27, 2026

Choose a reason for hiding this comment

Uh oh!

melinath Aug 26, 2026

Choose a reason for hiding this comment

Uh oh!

melinath Aug 27, 2026

Choose a reason for hiding this comment

Uh oh!

melinath Aug 26, 2026

Choose a reason for hiding this comment

Uh oh!

shahmedhaCorp Aug 26, 2026

Choose a reason for hiding this comment

Uh oh!

melinath Aug 27, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

shahmedhaCorp commented Aug 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

modular-magician commented Aug 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Diff report

Missing service labels

Test report

Analytics

Action taken

Uh oh!

melinath commented Aug 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

shahmedhaCorp commented Aug 20, 2026 •

edited by melinath

Loading

github-actions Bot commented Aug 20, 2026 •

edited

Loading

shahmedhaCorp commented Aug 26, 2026 •

edited

Loading

modular-magician commented Aug 26, 2026 •

edited

Loading

melinath commented Aug 26, 2026 •

edited

Loading