compute: make zone configurable on google_compute_future_reservation#18249
compute: make zone configurable on google_compute_future_reservation#18249GitOleksandrBokov wants to merge 2 commits into
zone configurable on google_compute_future_reservation#18249Conversation
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 42310d0: Diff reportYour PR generated the following diffs in downstream repositories:
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_compute_future_reservation" "primary" {
zone = # value needed
}
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode 🟢 All tests passed in Replaying mode! No Recording was needed. View the replaying VCR build log @GitOleksandrBokov VCR tests complete for 42310d0! |
zone was declared as an output-only property while base_url requires it as an input, so the resource could not be created unless a provider-level zone was set. Declare zone as an optional immutable parameter, following the compute.Disk pattern.
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit a037e2f: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
🟢 All tests passed! View the recording VCR build log or the debug logs folder for detailed results. @GitOleksandrBokov VCR tests complete for a037e2f! |
a037e2f to
b0fe9ef
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit b0fe9ef: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
🟢 All tests passed! View the recording VCR build log or the debug logs folder for detailed results. @GitOleksandrBokov VCR tests complete for b0fe9ef! |
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
google_compute_future_reservationcannot be created:zonewas declared as an output-only property, so the generated schema rejects any configured value (Can't configure a value for "zone"), while the create URL (projects/{{project}}/zones/{{zone}}/futureReservations) still requires it and fails withCannot determine zoneunless a provider-level zone is set.This PR declares
zoneas an optional immutable parameter with a provider-level fallback, following thecompute.Disk/compute.Reservationpattern. The generated schema becomesOptional + Computed + ForceNewwith self-link diff suppression, so both a zone name and a zone URL are accepted without a permadiff.Verified against the regenerated
google-betaprovider:terraform planwithzoneset on the resource succeeds (previously failed at plan time).terraform applybuilds the request URL from the configured zone.TestProvider) and compute unit tests pass.zonein config are unchanged (still resolved from the provider zone), so existing VCR cassettes stay valid.Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.