Skip to content

Dialogflow tool new#18235

Open
matt-degraffenreid wants to merge 3 commits into
GoogleCloudPlatform:mainfrom
matt-degraffenreid:dialogflow-tool-new
Open

Dialogflow tool new#18235
matt-degraffenreid wants to merge 3 commits into
GoogleCloudPlatform:mainfrom
matt-degraffenreid:dialogflow-tool-new

Conversation

@matt-degraffenreid

@matt-degraffenreid matt-degraffenreid commented Jul 9, 2026

Copy link
Copy Markdown

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

`google_dialogflow_tool`

Implemented google_dialogflow_tool resource in MMv1 with support for open_api_spec.
Added function_spec, connector_spec, and data_store_spec to Tool.yaml. Configured authentication options and marked sensitive fields. Also recorded
@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jul 9, 2026
@matt-degraffenreid matt-degraffenreid marked this pull request as ready for review July 9, 2026 17:44
@github-actions github-actions Bot requested a review from SirGitsalot July 9, 2026 17:44
@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions

Copy link
Copy Markdown

@SirGitsalot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@SirGitsalot SirGitsalot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems generally sound, but you need to add some sample tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-approval Pull requests that need reviewer's approval to run presubmit tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants