Remove beta restriction for ontapSource field in Backup resource

[ravisankardanda99]

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

netapp: added `ontap_source` field to `google_netapp_backup` resource (ga)

[github-actions]

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 59b2364:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
google provider	View Diff	3 files changed, 120 insertions(+), 1 deletion(-)
google-beta provider	View Diff	1 file changed, 1 insertion(+), 1 deletion(-)
terraform-google-conversion	View Diff	3 files changed, 135 insertions(+)

[ravisankardanda99]

Due to the reason mentioned in #17555 (#17555 (comment)), we cannot add an acceptance test for this change.

Local testing result:

[hi on] ravisankard@ravisankard-test:~/tf-testing$ cat main.tf 
provider "google" {
  project = "ritesh-gcnv-consumer"
  region  = "us-central1"
}

# Create the Backup Vault
resource "google_netapp_backup_vault" "vault" {
  name        = "test-terraform"
  location    = "us-central1"
  provider = google
}

resource "google_netapp_backup" "backup" {
  name        = "tf-test-backup"
  location    = "us-central1"
  vault_name  = google_netapp_backup_vault.vault.name
  description = "Manual backup using ontap_source"

  ontap_source {
    storage_pool  = "projects/ritesh-gcnv-consumer/locations/us-central1/storagePools/ontap-pool-ravisankard-test-1"
    volume_uuid   = "c82d8582-59b8-11f1-9394-97b5271c2d35"
  }
  provider = google
}
[hi on] ravisankard@ravisankard-test:~/tf-testing$ TF_CLI_CONFIG_FILE="$HOME/tf-dev-override.tfrc" terraform apply
╷
│ Warning: Provider development overrides are in effect
│ 
│ The following provider development overrides are set in the CLI configuration:
│  - hashicorp/google in /usr/local/google/home/ravisankard/go/bin
│  - hashicorp/google-beta in /usr/local/google/home/ravisankard/go/bin
│ 
│ The behavior may therefore not match any released version of the provider and applying changes may cause the state to become incompatible with published releases.
╵
google_netapp_backup_vault.vault: Refreshing state... [id=projects/ritesh-gcnv-consumer/locations/us-central1/backupVaults/test-terraform]

Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # google_netapp_backup.backup will be created
  + resource "google_netapp_backup" "backup" {
      + backup_region       = (known after apply)
      + backup_type         = (known after apply)
      + chain_storage_bytes = (known after apply)
      + create_time         = (known after apply)
      + deletion_policy     = "DELETE"
      + description         = "Manual backup using ontap_source"
      + effective_labels    = {
          + "goog-terraform-provisioned" = "true"
        }
      + id                  = (known after apply)
      + location            = "us-central1"
      + name                = "tf-test-backup"
      + project             = "ritesh-gcnv-consumer"
      + state               = (known after apply)
      + terraform_labels    = {
          + "goog-terraform-provisioned" = "true"
        }
      + vault_name          = "test-terraform"
      + volume_region       = (known after apply)
      + volume_usage_bytes  = (known after apply)

      + ontap_source {
          + snapshot_uuid = (known after apply)
          + storage_pool  = "projects/ritesh-gcnv-consumer/locations/us-central1/storagePools/ontap-pool-ravisankard-test-1"
          + volume_uuid   = "c82d8582-59b8-11f1-9394-97b5271c2d35"
        }
    }

Plan: 1 to add, 0 to change, 0 to destroy.

Do you want to perform these actions?
  Terraform will perform the actions described above.
  Only 'yes' will be accepted to approve.

  Enter a value: yes

google_netapp_backup.backup: Creating...
google_netapp_backup.backup: Still creating... [10s elapsed]
google_netapp_backup.backup: Still creating... [20s elapsed]
google_netapp_backup.backup: Still creating... [30s elapsed]
google_netapp_backup.backup: Still creating... [40s elapsed]
google_netapp_backup.backup: Still creating... [50s elapsed]
google_netapp_backup.backup: Still creating... [1m0s elapsed]
google_netapp_backup.backup: Still creating... [1m10s elapsed]
google_netapp_backup.backup: Still creating... [1m20s elapsed]
google_netapp_backup.backup: Still creating... [1m30s elapsed]
google_netapp_backup.backup: Still creating... [1m40s elapsed]
google_netapp_backup.backup: Still creating... [1m50s elapsed]
google_netapp_backup.backup: Still creating... [2m0s elapsed]
google_netapp_backup.backup: Creation complete after 2m3s [id=projects/ritesh-gcnv-consumer/locations/us-central1/backupVaults/test-terraform/backups/tf-test-backup]

Apply complete! Resources: 1 added, 0 changed, 0 destroyed.
[hi on] ravisankard@ravisankard-test:~/tf-testing$ TF_CLI_CONFIG_FILE="$HOME/tf-dev-override.tfrc" terraform apply
╷
│ Warning: Provider development overrides are in effect
│ 
│ The following provider development overrides are set in the CLI configuration:
│  - hashicorp/google-beta in /usr/local/google/home/ravisankard/go/bin
│  - hashicorp/google in /usr/local/google/home/ravisankard/go/bin
│ 
│ The behavior may therefore not match any released version of the provider and applying changes may cause the state to become incompatible with published releases.
╵
google_netapp_backup_vault.vault: Refreshing state... [id=projects/ritesh-gcnv-consumer/locations/us-central1/backupVaults/test-terraform]
google_netapp_backup.backup: Refreshing state... [id=projects/ritesh-gcnv-consumer/locations/us-central1/backupVaults/test-terraform/backups/tf-test-backup]

No changes. Your infrastructure matches the configuration.

Terraform has compared your real infrastructure against your configuration and found no differences, so no changes are needed.

Apply complete! Resources: 0 added, 0 changed, 0 destroyed.
[hi on] ravisankard@ravisankard-test:~/tf-testing$

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 51e6fc7:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
google provider	View Diff	3 files changed, 121 insertions(+), 1 deletion(-)
google-beta provider	View Diff	2 files changed, 2 insertions(+), 1 deletion(-)
terraform-google-conversion	View Diff	3 files changed, 130 insertions(+)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_netapp_backup (7 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_netapp_backup" "primary" {
  ontap_source {
    snapshot_uuid = # value needed
  }
}

Test report

Analytics

Total Tests	Passed	Skipped	Affected
43	43	0	0

Affected Service Packages

• netapp

Learn how VCR tests work

---

Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@ravisankardanda99, @zli82016 VCR tests complete for 51e6fc7!