Skip to content

bigquery: fix TestAccBigQueryDataset_collationUpdate#17744

Open
BBBmau wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
BBBmau:fix-bigquery-dataset-collation-diff
Open

bigquery: fix TestAccBigQueryDataset_collationUpdate#17744
BBBmau wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
BBBmau:fix-bigquery-dataset-collation-diff

Conversation

@BBBmau
Copy link
Copy Markdown
Collaborator

@BBBmau BBBmau commented May 27, 2026

We've been getting failures due to the collation diff failing when going from a value to a "" value.

------- Stdout: -------
=== RUN   TestAccBigQueryDataset_collationUpdate
=== PAUSE TestAccBigQueryDataset_collationUpdate
=== CONT  TestAccBigQueryDataset_collationUpdate
    resource_bigquery_dataset_test.go:592: Step 3/4 error: Check failed: Check 1/2 error: Check 1/1 error: google_bigquery_dataset.test: Attribute 'default_collation' expected "", got "und:ci"
--- FAIL: TestAccBigQueryDataset_collationUpdate (17.44s)
FAIL

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 27, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 901c591:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 2 insertions(+), 8 deletions(-)
google-beta provider View Diff 1 file changed, 2 insertions(+), 8 deletions(-)
terraform-google-conversion View Diff 2 files changed, 4 insertions(+), 16 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
152 142 10 0
Affected Service Packages
  • bigquery

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@BBBmau, @sachinpro VCR tests complete for 901c591!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants