Skip to content

Add Google Cloud Network Connectivity CustomHardwareInstance resource#17741

Open
shengquan-ni wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
shengquan-ni:add-custom-hardware-instance
Open

Add Google Cloud Network Connectivity CustomHardwareInstance resource#17741
shengquan-ni wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
shengquan-ni:add-custom-hardware-instance

Conversation

@shengquan-ni
Copy link
Copy Markdown

@shengquan-ni shengquan-ni commented May 26, 2026

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

Part of hashicorp/terraform-provider-google#27551

`google_network_connectivity_custom_hardware_instance`

@github-actions github-actions Bot requested a review from melinath May 26, 2026 22:14
@github-actions
Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 26, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit e41cc93:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 157 insertions(+)
google-beta provider View Diff 5 files changed, 1223 insertions(+)
terraform-google-conversion View Diff 1 file changed, 132 insertions(+)

Missing service labels

The following new resources do not have corresponding service labels:

  • google_network_connectivity_custom_hardware_instance

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

Test report

Important

Manual Verification Required

VCR cannot automatically execute the following tests added in this PR. Please verify them manually:

🔴 TestAccNetworkConnectivityCustomHardwareInstance_networkConnectivityCustomHardwareInstanceBasicExample

Analytics

Total Tests Passed Skipped Affected
40 38 2 0
Affected Service Packages
  • networkconnectivity

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

Caution

Issues requiring attention before PR completion

🔴 Manual Verification Required: New tests were added that are skipped in presubmit tests. See the "Manual Verification Required" section at the top for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the replaying VCR build log

@shengquan-ni, @melinath VCR tests complete for e41cc93!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants