Add VertexAI RagCorpus and tests#17740
Conversation
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 47a65ca: Diff reportYour PR generated the following diffs in downstream repositories:
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_vertex_ai_rag_corpus" "primary" {
encryption_spec {
kms_key_name = # value needed
}
vector_db_config {
api_auth {
api_key_config {
api_key_secret_version = # value needed
api_key_string = # value needed
}
}
pinecone {
index_name = # value needed
}
vertex_vector_search {
index = # value needed
index_endpoint = # value needed
}
}
vertex_ai_search_config {
serving_config = # value needed
}
}
Missing service labelsThe following new resources do not have corresponding service labels:
If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels. Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
🟢 All tests passed! View the recording VCR build log or the debug logs folder for detailed results. @slevenick VCR tests complete for 47a65ca! |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit d2f604e: Diff reportYour PR generated the following diffs in downstream repositories:
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_vertex_ai_rag_corpus" "primary" {
encryption_spec {
kms_key_name = # value needed
}
vector_db_config {
pinecone {
index_name = # value needed
}
vertex_vector_search {
index = # value needed
index_endpoint = # value needed
}
}
vertex_ai_search_config {
serving_config = # value needed
}
}
Missing service labelsThe following new resources do not have corresponding service labels:
If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels. Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode 🟢 All tests passed in Replaying mode! No Recording was needed. View the replaying VCR build log @slevenick VCR tests complete for d2f604e! |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit c659893: Diff reportYour PR generated the following diffs in downstream repositories:
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_vertex_ai_rag_corpus" "primary" {
encryption_spec {
kms_key_name = # value needed
}
vector_db_config {
pinecone {
index_name = # value needed
}
vertex_vector_search {
index = # value needed
index_endpoint = # value needed
}
}
vertex_ai_search_config {
serving_config = # value needed
}
}
Missing service labelsThe following new resources do not have corresponding service labels:
If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels. Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode 🟢 All tests passed in Replaying mode! No Recording was needed. View the replaying VCR build log @slevenick VCR tests complete for c659893! |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 31a604a: Diff reportYour PR generated the following diffs in downstream repositories:
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_vertex_ai_rag_corpus" "primary" {
encryption_spec {
kms_key_name = # value needed
}
vector_db_config {
pinecone {
index_name = # value needed
}
vertex_vector_search {
index = # value needed
index_endpoint = # value needed
}
}
vertex_ai_search_config {
serving_config = # value needed
}
}
Missing service labelsThe following new resources do not have corresponding service labels:
If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels. Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode 🟢 All tests passed in Replaying mode! No Recording was needed. View the replaying VCR build log @slevenick VCR tests complete for 31a604a! |
c659893 to
13509f4
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 13509f4: Diff reportYour PR generated the following diffs in downstream repositories:
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_vertex_ai_rag_corpus" "primary" {
encryption_spec {
kms_key_name = # value needed
}
vector_db_config {
pinecone {
index_name = # value needed
}
vertex_vector_search {
index = # value needed
index_endpoint = # value needed
}
}
vertex_ai_search_config {
serving_config = # value needed
}
}
Missing service labelsThe following new resources do not have corresponding service labels:
If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels. Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode 🟢 All tests passed in Replaying mode! No Recording was needed. View the replaying VCR build log @slevenick VCR tests complete for 13509f4! |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 7b14e82: Diff reportYour PR generated the following diffs in downstream repositories:
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_vertex_ai_rag_corpus" "primary" {
vector_db_config {
pinecone {
index_name = # value needed
}
vertex_vector_search {
index = # value needed
index_endpoint = # value needed
}
}
vertex_ai_search_config {
serving_config = # value needed
}
}
Missing service labelsThe following new resources do not have corresponding service labels:
If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels. Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
🟢 All tests passed! View the recording VCR build log or the debug logs folder for detailed results. @slevenick VCR tests complete for 7b14e82! |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit e230cc9: Diff reportYour PR generated the following diffs in downstream repositories:
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_vertex_ai_rag_corpus" "primary" {
vector_db_config {
vertex_vector_search {
index = # value needed
index_endpoint = # value needed
}
}
}
Missing service labelsThe following new resources do not have corresponding service labels:
If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels. Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
🟢 All tests passed! View the recording VCR build log or the debug logs folder for detailed results. @slevenick VCR tests complete for e230cc9! |
|
@modular-magician reassign-reviewer |
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.