Skip to content

Add VertexAI RagCorpus and tests#17740

Open
slevenick wants to merge 6 commits into
GoogleCloudPlatform:mainfrom
slevenick:vertex-rag-corpus
Open

Add VertexAI RagCorpus and tests#17740
slevenick wants to merge 6 commits into
GoogleCloudPlatform:mainfrom
slevenick:vertex-rag-corpus

Conversation

@slevenick
Copy link
Copy Markdown
Contributor

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

`google_vertex_ai_rag_corpus`

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 26, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 47a65ca:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 5 files changed, 2336 insertions(+)
google-beta provider View Diff 5 files changed, 2336 insertions(+)
terraform-google-conversion View Diff 1 file changed, 517 insertions(+)
Open in Cloud Shell View Diff 4 files changed, 114 insertions(+)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_vertex_ai_rag_corpus (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_vertex_ai_rag_corpus" "primary" {
  encryption_spec {
    kms_key_name = # value needed
  }
  vector_db_config {
    api_auth {
      api_key_config {
        api_key_secret_version = # value needed
        api_key_string         = # value needed
      }
    }
    pinecone {
      index_name = # value needed
    }
    vertex_vector_search {
      index          = # value needed
      index_endpoint = # value needed
    }
  }
  vertex_ai_search_config {
    serving_config = # value needed
  }
}

Missing service labels

The following new resources do not have corresponding service labels:

  • google_vertex_ai_rag_corpus

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

Test report

Analytics

Total Tests Passed Skipped Affected
97 91 4 2
Affected Service Packages
  • vertexai

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccVertexAIRagCorpus_vertexAiRagCorpusBasicExample
  • TestAccVertexAIRagCorpus_vertexAiRagCorpusFullExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccVertexAIRagCorpus_vertexAiRagCorpusBasicExample
✅ Log TestAccVertexAIRagCorpus_vertexAiRagCorpusFullExample

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@slevenick VCR tests complete for 47a65ca!

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 26, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit d2f604e:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 5 files changed, 2136 insertions(+)
google-beta provider View Diff 5 files changed, 2136 insertions(+)
terraform-google-conversion View Diff 1 file changed, 440 insertions(+)
Open in Cloud Shell View Diff 4 files changed, 114 insertions(+)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_vertex_ai_rag_corpus (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_vertex_ai_rag_corpus" "primary" {
  encryption_spec {
    kms_key_name = # value needed
  }
  vector_db_config {
    pinecone {
      index_name = # value needed
    }
    vertex_vector_search {
      index          = # value needed
      index_endpoint = # value needed
    }
  }
  vertex_ai_search_config {
    serving_config = # value needed
  }
}

Missing service labels

The following new resources do not have corresponding service labels:

  • google_vertex_ai_rag_corpus

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

Test report

Analytics

Total Tests Passed Skipped Affected
97 93 4 0
Affected Service Packages
  • vertexai

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@slevenick VCR tests complete for d2f604e!

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 26, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit c659893:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 5 files changed, 2136 insertions(+)
google-beta provider View Diff 5 files changed, 2136 insertions(+)
terraform-google-conversion View Diff 1 file changed, 440 insertions(+)
Open in Cloud Shell View Diff 4 files changed, 114 insertions(+)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_vertex_ai_rag_corpus (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_vertex_ai_rag_corpus" "primary" {
  encryption_spec {
    kms_key_name = # value needed
  }
  vector_db_config {
    pinecone {
      index_name = # value needed
    }
    vertex_vector_search {
      index          = # value needed
      index_endpoint = # value needed
    }
  }
  vertex_ai_search_config {
    serving_config = # value needed
  }
}

Missing service labels

The following new resources do not have corresponding service labels:

  • google_vertex_ai_rag_corpus

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

Test report

Analytics

Total Tests Passed Skipped Affected
97 93 4 0
Affected Service Packages
  • vertexai

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@slevenick VCR tests complete for c659893!

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 26, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 31a604a:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 5 files changed, 2136 insertions(+)
google-beta provider View Diff 5 files changed, 2136 insertions(+)
terraform-google-conversion View Diff 1 file changed, 440 insertions(+)
Open in Cloud Shell View Diff 4 files changed, 114 insertions(+)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_vertex_ai_rag_corpus (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_vertex_ai_rag_corpus" "primary" {
  encryption_spec {
    kms_key_name = # value needed
  }
  vector_db_config {
    pinecone {
      index_name = # value needed
    }
    vertex_vector_search {
      index          = # value needed
      index_endpoint = # value needed
    }
  }
  vertex_ai_search_config {
    serving_config = # value needed
  }
}

Missing service labels

The following new resources do not have corresponding service labels:

  • google_vertex_ai_rag_corpus

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

Test report

Analytics

Total Tests Passed Skipped Affected
97 93 4 0
Affected Service Packages
  • vertexai

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@slevenick VCR tests complete for 31a604a!

@slevenick slevenick force-pushed the vertex-rag-corpus branch from c659893 to 13509f4 Compare May 26, 2026 22:23
@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 26, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 13509f4:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 5 files changed, 2136 insertions(+)
google-beta provider View Diff 5 files changed, 2136 insertions(+)
terraform-google-conversion View Diff 1 file changed, 440 insertions(+)
Open in Cloud Shell View Diff 4 files changed, 114 insertions(+)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_vertex_ai_rag_corpus (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_vertex_ai_rag_corpus" "primary" {
  encryption_spec {
    kms_key_name = # value needed
  }
  vector_db_config {
    pinecone {
      index_name = # value needed
    }
    vertex_vector_search {
      index          = # value needed
      index_endpoint = # value needed
    }
  }
  vertex_ai_search_config {
    serving_config = # value needed
  }
}

Missing service labels

The following new resources do not have corresponding service labels:

  • google_vertex_ai_rag_corpus

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

Test report

Analytics

Total Tests Passed Skipped Affected
97 93 4 0
Affected Service Packages
  • vertexai

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@slevenick VCR tests complete for 13509f4!

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 26, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 7b14e82:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 5 files changed, 2157 insertions(+)
google-beta provider View Diff 5 files changed, 2157 insertions(+)
terraform-google-conversion View Diff 1 file changed, 440 insertions(+)
Open in Cloud Shell View Diff 4 files changed, 114 insertions(+)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_vertex_ai_rag_corpus (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_vertex_ai_rag_corpus" "primary" {
  vector_db_config {
    pinecone {
      index_name = # value needed
    }
    vertex_vector_search {
      index          = # value needed
      index_endpoint = # value needed
    }
  }
  vertex_ai_search_config {
    serving_config = # value needed
  }
}

Missing service labels

The following new resources do not have corresponding service labels:

  • google_vertex_ai_rag_corpus

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

Test report

Analytics

Total Tests Passed Skipped Affected
97 92 4 1
Affected Service Packages
  • vertexai

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccVertexAIRagCorpus_vertexAiRagCorpusFullExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccVertexAIRagCorpus_vertexAiRagCorpusFullExample

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@slevenick VCR tests complete for 7b14e82!

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 27, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit e230cc9:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 5 files changed, 2245 insertions(+)
google-beta provider View Diff 5 files changed, 2245 insertions(+)
terraform-google-conversion View Diff 1 file changed, 440 insertions(+)
Open in Cloud Shell View Diff 8 files changed, 225 insertions(+)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_vertex_ai_rag_corpus (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_vertex_ai_rag_corpus" "primary" {
  vector_db_config {
    vertex_vector_search {
      index          = # value needed
      index_endpoint = # value needed
    }
  }
}

Missing service labels

The following new resources do not have corresponding service labels:

  • google_vertex_ai_rag_corpus

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

Test report

Analytics

Total Tests Passed Skipped Affected
99 93 4 2
Affected Service Packages
  • vertexai

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccVertexAIRagCorpus_vertexAiRagCorpusPineconeExample
  • TestAccVertexAIRagCorpus_vertexAiRagCorpusSearchConfigExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccVertexAIRagCorpus_vertexAiRagCorpusPineconeExample
✅ Log TestAccVertexAIRagCorpus_vertexAiRagCorpusSearchConfigExample

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@slevenick VCR tests complete for e230cc9!

@slevenick slevenick requested review from a team and ScottSuarez and removed request for a team May 27, 2026 16:45
@slevenick
Copy link
Copy Markdown
Contributor Author

@modular-magician reassign-reviewer

@github-actions
Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions Bot requested a review from NickElliot May 27, 2026 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants