Migrate expandDisplayDevice, flattenEnableDisplay functions in compute_instance_helpers.go.tmpl to use direct HTTP rather than a client library

[nsamartsev]

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: Migrate `expandDisplayDevice`, `flattenEnableDisplay` functions in `compute_instance_helpers.go.tmpl` to use direct HTTP rather than a client library

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit cf4b522:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
google provider	View Diff	1 file changed, 5 insertions(+), 6 deletions(-)
google-beta provider	View Diff	1 file changed, 5 insertions(+), 6 deletions(-)
terraform-google-conversion	View Diff	2 files changed, 10 insertions(+), 12 deletions(-)

Errors

google provider:

• The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

• The diff processor failed to build. This is usually due to the downstream provider failing to compile.

Step 1: Replaying Mode

Caution

Build Failure during VCR tests

🔴 REPLAYING mode: The following packages failed to build:

• compute

Please fix the compilation errors to complete your PR.

View the build log

@nsamartsev VCR tests complete for cf4b522!

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit a1caf9c:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
google provider	View Diff	3 files changed, 25 insertions(+), 11 deletions(-)
google-beta provider	View Diff	5 files changed, 43 insertions(+), 23 deletions(-)
terraform-google-conversion	View Diff	2 files changed, 10 insertions(+), 12 deletions(-)

Test report

Analytics

Total Tests	Passed	Skipped	Affected
1457	1362	93	2

Affected Service Packages

• compute

Learn how VCR tests work

---

Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests

• TestAccComputeRouterPeer_AddMd5AuthenticationKey
• TestAccComputeRouterPeer_UpdateMd5AuthenticationKey

View the replaying VCR build log

---

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
✅ Log	✅	TestAccComputeRouterPeer_AddMd5AuthenticationKey
✅ Log	✅	TestAccComputeRouterPeer_UpdateMd5AuthenticationKey

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@nsamartsev VCR tests complete for a1caf9c!

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 411a1d3:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
google provider	View Diff	3 files changed, 25 insertions(+), 11 deletions(-)
google-beta provider	View Diff	5 files changed, 43 insertions(+), 23 deletions(-)
terraform-google-conversion	View Diff	4 files changed, 29 insertions(+), 18 deletions(-)

Test report

Analytics

Total Tests	Passed	Skipped	Affected
1457	1364	93	0

Affected Service Packages

• compute

Learn how VCR tests work

---

Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@nsamartsev VCR tests complete for 411a1d3!

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit b849920:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
google provider	View Diff	3 files changed, 25 insertions(+), 11 deletions(-)
google-beta provider	View Diff	5 files changed, 43 insertions(+), 23 deletions(-)
terraform-google-conversion	View Diff	5 files changed, 34 insertions(+), 19 deletions(-)

Test report

Analytics

Total Tests	Passed	Skipped	Affected
1457	1364	93	0

Affected Service Packages

• compute

Learn how VCR tests work

---

Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@nsamartsev VCR tests complete for b849920!

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 0361e6a:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
google provider	View Diff	3 files changed, 25 insertions(+), 11 deletions(-)
google-beta provider	View Diff	5 files changed, 43 insertions(+), 23 deletions(-)
terraform-google-conversion	View Diff	5 files changed, 34 insertions(+), 19 deletions(-)

Test report

Analytics

Total Tests	Passed	Skipped	Affected
1462	1369	93	0

Affected Service Packages

• compute

Learn how VCR tests work

---

Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@nsamartsev VCR tests complete for 0361e6a!

[github-actions]

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.