Skip to content

Migrated compute_instance_helpers.go.tmpl partially to use transport_tpg.SendRequest#17717

Draft
nsamartsev wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
nsamartsev:compute-instance-helpers-expandComputePreemptionNoticeDuration-migration
Draft

Migrated compute_instance_helpers.go.tmpl partially to use transport_tpg.SendRequest#17717
nsamartsev wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
nsamartsev:compute-instance-helpers-expandComputePreemptionNoticeDuration-migration

Conversation

@nsamartsev
Copy link
Copy Markdown
Contributor

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: Migrated compute_instance_helpers.go.tmpl partially to use transport_tpg.SendRequest. Methods: expandComputeOnInstanceStopAction, expandComputePreemptionNoticeDuration

@nsamartsev nsamartsev force-pushed the compute-instance-helpers-expandComputePreemptionNoticeDuration-migration branch from 18e061a to a34bf59 Compare May 25, 2026 09:20
@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 25, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit a34bf59:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 9 insertions(+), 5 deletions(-)
google-beta provider View Diff 1 file changed, 19 insertions(+), 11 deletions(-)
terraform-google-conversion View Diff 4 files changed, 130 insertions(+), 17 deletions(-)

Step 1: Replaying Mode

Caution

Panic occurred during VCR tests

🔴 REPLAYING mode: The provider crashed with a panic. Please check the build log for details.

Please fix the issue to complete your PR.

View the build log

@nsamartsev VCR tests complete for a34bf59!

…tpg.SendRequest. Methods: expandComputeOnInstanceStopAction, expandComputePreemptionNoticeDuration
@nsamartsev nsamartsev force-pushed the compute-instance-helpers-expandComputePreemptionNoticeDuration-migration branch from a34bf59 to 9afc56a Compare May 25, 2026 09:30
@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 25, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 9afc56a:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 9 insertions(+), 5 deletions(-)
google-beta provider View Diff 1 file changed, 19 insertions(+), 11 deletions(-)
terraform-google-conversion View Diff 4 files changed, 130 insertions(+), 17 deletions(-)

Step 1: Replaying Mode

Caution

Panic occurred during VCR tests

🔴 REPLAYING mode: The provider crashed with a panic. Please check the build log for details.

Please fix the issue to complete your PR.

View the build log

@nsamartsev VCR tests complete for 9afc56a!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants