added GA support for largeCapacityConfig by raazanand · Pull Request #17077 · GoogleCloudPlatform/magic-modules

raazanand · 2026-04-10T18:21:08Z

netapp: added GA support for largeCapacityConfig field

github-actions · 2026-04-10T18:22:16Z

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

modular-magician · 2026-04-10T18:32:57Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 95 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
terraform-google-conversion: Diff ( 3 files changed, 82 insertions(+))

modular-magician · 2026-04-10T19:36:30Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 95 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
terraform-google-conversion: Diff ( 3 files changed, 82 insertions(+))

modular-magician · 2026-04-11T07:35:26Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 101 insertions(+), 7 deletions(-))
google-beta provider: Diff ( 2 files changed, 7 insertions(+), 7 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 82 insertions(+))

modular-magician · 2026-04-11T08:08:03Z

Tests analytics

Total tests: 42
Passed tests: 41
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2026-04-11T08:49:17Z

🔴 Tests failed during RECORDING mode:
TestAccNetappVolume_LargeCapacityScaleTypeConfig [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2026-04-11T11:12:55Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 99 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 2 files changed, 5 insertions(+), 5 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 82 insertions(+))

modular-magician · 2026-04-11T11:46:03Z

Tests analytics

Total tests: 42
Passed tests: 41
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2026-04-11T12:32:36Z

🟢 Tests passed during RECORDING mode:
TestAccNetappVolume_LargeCapacityScaleTypeConfig [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

modular-magician · 2026-04-12T04:04:29Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 103 insertions(+), 13 deletions(-))
google-beta provider: Diff ( 3 files changed, 9 insertions(+), 13 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 82 insertions(+))

modular-magician · 2026-04-12T04:35:10Z

Tests analytics

Total tests: 42
Passed tests: 40
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2026-04-12T04:35:27Z

🔴 Tests failed during RECORDING mode:
TestAccNetappStoragePool_ScaleType [Error message] [Debug log]
TestAccNetappVolume_LargeCapacityScaleTypeConfig [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2026-04-12T05:15:41Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 103 insertions(+), 17 deletions(-))
google-beta provider: Diff ( 3 files changed, 9 insertions(+), 17 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 82 insertions(+))

modular-magician · 2026-04-12T05:46:20Z

Tests analytics

Total tests: 42
Passed tests: 40
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2026-04-12T05:46:38Z

🔴 Tests failed during RECORDING mode:
TestAccNetappStoragePool_ScaleType [Error message] [Debug log]
TestAccNetappVolume_LargeCapacityScaleTypeConfig [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2026-04-12T07:13:01Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 105 insertions(+), 19 deletions(-))
google-beta provider: Diff ( 3 files changed, 11 insertions(+), 19 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 82 insertions(+))

modular-magician · 2026-04-12T07:42:05Z

Tests analytics

Total tests: 42
Passed tests: 40
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2026-04-12T08:28:51Z

🟢 Tests passed during RECORDING mode:
TestAccNetappStoragePool_ScaleType [Debug log]
TestAccNetappVolume_LargeCapacityScaleTypeConfig [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

modular-magician · 2026-04-13T16:14:54Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 109 insertions(+), 23 deletions(-))
google-beta provider: Diff ( 5 files changed, 15 insertions(+), 23 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 82 insertions(+))

modular-magician · 2026-04-13T16:45:33Z

Tests analytics

Total tests: 42
Passed tests: 42
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

🟢 All tests passed!

View the build log

c2thorn

I'll run the

c2thorn · 2026-04-13T16:53:37Z

@@ -931,14 +931,13 @@ func TestAccNetappStoragePool_ScaleType(t *testing.T) {
 func testAccNetappStoragePool_ScaleType(context map[string]interface{}) string {


this test doesn't seem to actually use the promoted field? in fact, I can't find that field tested in this file at all

The scale_type field was already present; I simply refactored some code.

This has nothing to do with largeCapacityConfig; largeCapacityConfig requires a valid pool's scale_type value.

c2thorn

noting that there is no test for largeCapacityConfig, but this just makes that true for both GA and beta now.

added GA support for largeCapacityConfig

a45c5a3

github-actions bot requested a review from c2thorn April 10, 2026 18:22

modular-magician added the service/netapp label Apr 10, 2026

raazanand marked this pull request as draft April 10, 2026 19:22

Trigger Build

b3b712e

modified testAccNetappVolume_LargeCapacityScaleTypeConfig_basic function

605f4fc

chnaged location

41f530c

added GA support for largeCapacityConfig

bd38153

fixed failures

95df420

ProtoV5ProviderFactories support added

7d99ede

raazanand marked this pull request as ready for review April 12, 2026 08:41

increase timeout for sp

7bf103b

c2thorn requested changes Apr 13, 2026

View reviewed changes

c2thorn approved these changes Apr 14, 2026

View reviewed changes

c2thorn added this pull request to the merge queue Apr 14, 2026

Merged via the queue into GoogleCloudPlatform:main with commit 0b7fc09 Apr 14, 2026
22 of 23 checks passed

		@@ -931,14 +931,13 @@ func TestAccNetappStoragePool_ScaleType(t *testing.T) {
		func testAccNetappStoragePool_ScaleType(context map[string]interface{}) string {

Conversation

raazanand commented Apr 10, 2026

Uh oh!

github-actions bot commented Apr 10, 2026

Uh oh!

modular-magician commented Apr 10, 2026

Diff report

Uh oh!

modular-magician commented Apr 10, 2026

Diff report

Uh oh!

modular-magician commented Apr 11, 2026

Diff report

Uh oh!

modular-magician commented Apr 11, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Apr 11, 2026

Uh oh!

modular-magician commented Apr 11, 2026

Diff report

Uh oh!

modular-magician commented Apr 11, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Apr 11, 2026

Uh oh!

modular-magician commented Apr 12, 2026

Diff report

Uh oh!

modular-magician commented Apr 12, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Apr 12, 2026

Uh oh!

modular-magician commented Apr 12, 2026

Diff report

Uh oh!

modular-magician commented Apr 12, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Apr 12, 2026

Uh oh!

modular-magician commented Apr 12, 2026

Diff report

Uh oh!

modular-magician commented Apr 12, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Apr 12, 2026

Uh oh!

modular-magician commented Apr 13, 2026

Diff report

Uh oh!

modular-magician commented Apr 13, 2026

Tests analytics

Uh oh!

c2thorn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

c2thorn Apr 13, 2026

Choose a reason for hiding this comment

Uh oh!

raazanand Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

raazanand Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

c2thorn left a comment

Choose a reason for hiding this comment

Uh oh!

raazanand Apr 13, 2026 •

edited

Loading

raazanand Apr 13, 2026 •

edited

Loading