Feature: Create datalineage config provider by pawelmarut · Pull Request #17073 · GoogleCloudPlatform/magic-modules

pawelmarut · 2026-04-10T10:54:47Z

Terraform resource and datasource for data lineage configuration.

Release Note Template for Downstream PRs (will be copied)

`google_data_lineage_config`

`google_data_lineage_config`

google-cla · 2026-04-10T10:54:59Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

github-actions · 2026-04-10T10:55:19Z

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@malhotrasagar2212, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

github-actions · 2026-04-15T10:03:08Z

@slevenick This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

zli82016 · 2026-04-15T17:02:03Z

@modular-magician reassign-reviewer

zli82016 · 2026-04-15T17:14:07Z

Reassigned the review to @malhotrasagar2212, as the original reviewer is OOO

zli82016 · 2026-04-15T18:00:02Z

+
+examples:
+  - name: 'data_lineage_config_basic'
+    config_path: 'templates/terraform/examples/data_lineage_config_basic.tf.tmpl'


config_path is not needed, as the file templates/terraform/examples/data_lineage_config_basic.tf.tmpl will be used to generate the test automatically by matching the example name.

zli82016 · 2026-04-15T18:02:18Z

+                    Integration to which the rule applies.
+                  required: true
+                  enum_values:
+                    - 'INTEGRATION_UNSPECIFIED'


INTEGRATION_UNSPECIFIED is meaningless and can be removed.

zli82016 · 2026-04-15T18:02:45Z

@@ -0,0 +1,23 @@
+# Copyright 2024 Google Inc.


Suggested change

# Copyright 2024 Google Inc.

# Copyright 2026 Google Inc.

zli82016 · 2026-04-15T18:07:34Z

+custom_code:
+  test_check_destroy: 'templates/terraform/custom_check_destroy/datalineage_config.go.tmpl'
+
+examples:


Can you also add the examples for folder config and org config?

modular-magician · 2026-04-15T18:17:18Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 17 files changed, 1396 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 15 files changed, 1386 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 257 insertions(+))

Missing service labels

The following new resources do not have corresponding service labels:

google_data_lineage_config

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

modular-magician · 2026-04-15T20:44:56Z

Tests analytics

Total tests: 6302
Passed tests: 5635
Skipped tests: 651
Affected tests: 16

Click here to see the affected service packages

All service packages are affected

Action taken

Found 16 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAccessContextManager__access_policy_iam_policy

TestAccApigeeOrganization_apigeeOrganizationCloudBasicDisableVpcPeeringTestExample

TestAccApigeeOrganization_apigeeOrganizationCloudFullDisableVpcPeeringTestExample

TestAccArtifactRegistryRepository_artifactRegistryRepositoryCleanupExample

TestAccArtifactRegistryRepository_cleanup

TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample

TestAccCloudRunService_cloudRunServiceGpuExample

TestAccContainerCluster_withAutopilotResourceManagerTags

TestAccDataLineageConfig_dataLineageConfigBasicExample

TestAccDataLineageConfig_update

TestAccDataSourceGoogleBackupDRManagementServer_basic

TestAccDataSourceGoogleDataLineageConfig_basic

TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample

TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample

TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample

TestAccPubsubSubscription_pubsubSubscriptionTagsExample

Get to know how VCR tests work

modular-magician · 2026-04-15T21:24:09Z

🟢 Tests passed during RECORDING mode:
TestAccAccessContextManager__access_level [Debug log]
TestAccAccessContextManager__access_level_condition [Debug log]
TestAccAccessContextManager__access_level_custom [Debug log]
TestAccAccessContextManager__access_level_full [Debug log]
TestAccAccessContextManager__access_levels [Debug log]
TestAccAccessContextManager__access_policy [Debug log]
TestAccAccessContextManager__access_policy_iam_binding [Debug log]
TestAccAccessContextManager__access_policy_iam_member [Debug log]
TestAccAccessContextManager__access_policy_scoped [Debug log]
TestAccAccessContextManager__authorized_orgs_desc [Debug log]
TestAccAccessContextManager__data_source_access_policy_basic [Debug log]
TestAccAccessContextManager__data_source_access_policy_scoped [Debug log]
TestAccAccessContextManager__gcp_user_access_binding [Debug log]
TestAccAccessContextManager__service_perimeter [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_egress_policy [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_ingress_policy [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_resource [Debug log]
TestAccAccessContextManager__service_perimeter_egress_policy [Debug log]
TestAccAccessContextManager__service_perimeter_ingress_policy [Debug log]
TestAccAccessContextManager__service_perimeter_resource [Debug log]
TestAccAccessContextManager__service_perimeter_update [Debug log]
TestAccAccessContextManager__service_perimeters [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccAccessContextManager__access_policy_iam_policy [Error message] [Debug log]
TestAccApigeeOrganization_apigeeOrganizationCloudBasicDisableVpcPeeringTestExample [Error message] [Debug log]
TestAccApigeeOrganization_apigeeOrganizationCloudFullDisableVpcPeeringTestExample [Error message] [Debug log]
TestAccArtifactRegistryRepository_artifactRegistryRepositoryCleanupExample [Error message] [Debug log]
TestAccArtifactRegistryRepository_cleanup [Error message] [Debug log]
TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample [Error message] [Debug log]
TestAccCloudRunService_cloudRunServiceGpuExample [Error message] [Debug log]
TestAccContainerCluster_withAutopilotResourceManagerTags [Error message] [Debug log]
TestAccDataLineageConfig_dataLineageConfigBasicExample [Error message] [Debug log]
TestAccDataLineageConfig_update [Error message] [Debug log]
TestAccDataSourceGoogleBackupDRManagementServer_basic [Error message] [Debug log]
TestAccDataSourceGoogleDataLineageConfig_basic [Error message] [Debug log]
TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample [Error message] [Debug log]
TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample [Error message] [Debug log]
TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample [Error message] [Debug log]
TestAccPubsubSubscription_pubsubSubscriptionTagsExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

pawelmarut · 2026-04-16T14:43:52Z

Hi,
@zli82016, could you please help resolve this problem? It reports that the test project doesn't have the datalineage API enabled. Do you know how I can enable it?
Error message:
"Data Lineage API has not been used in project 1067888929963 before or it is disabled. Enable it by visiting https://console.developers.google.com/apis/api/datalineage.googleapis.com/overview?project=1067888929963 then retry. If you enabled this API recently, wait a few minutes for the action to propagate to our systems and retry."

zli82016 · 2026-04-16T17:01:49Z

https://console.developers.google.com/apis/api/datalineage.googleapis.com/overview?project=1067888929963

I enabled the datalineage API

zli82016 · 2026-04-16T17:02:23Z

/gcbrun

modular-magician · 2026-04-16T17:17:07Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 17 files changed, 1396 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 15 files changed, 1386 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 257 insertions(+))

Missing service labels

The following new resources do not have corresponding service labels:

google_data_lineage_config

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

modular-magician · 2026-04-16T19:44:08Z

Tests analytics

Total tests: 6311
Passed tests: 5648
Skipped tests: 651
Affected tests: 12

Click here to see the affected service packages

All service packages are affected

Action taken

Found 12 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccApigeeOrganization_apigeeOrganizationCloudBasicDisableVpcPeeringTestExample

TestAccApigeeOrganization_apigeeOrganizationCloudFullDisableVpcPeeringTestExample

TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample

TestAccCloudRunService_cloudRunServiceGpuExample

TestAccContainerCluster_withAutopilotResourceManagerTags

TestAccDataLineageConfig_dataLineageConfigBasicExample

TestAccDataSourceGoogleBackupDRManagementServer_basic

TestAccDataformConfig_update

TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample

TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample

TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample

TestAccPubsubSubscription_pubsubSubscriptionTagsExample

Get to know how VCR tests work

modular-magician · 2026-04-16T20:20:37Z

🟢 Tests passed during RECORDING mode:
TestAccDataLineageConfig_dataLineageConfigBasicExample [Debug log]
TestAccDataformConfig_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccApigeeOrganization_apigeeOrganizationCloudBasicDisableVpcPeeringTestExample [Error message] [Debug log]
TestAccApigeeOrganization_apigeeOrganizationCloudFullDisableVpcPeeringTestExample [Error message] [Debug log]
TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample [Error message] [Debug log]
TestAccCloudRunService_cloudRunServiceGpuExample [Error message] [Debug log]
TestAccContainerCluster_withAutopilotResourceManagerTags [Error message] [Debug log]
TestAccDataSourceGoogleBackupDRManagementServer_basic [Error message] [Debug log]
TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample [Error message] [Debug log]
TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample [Error message] [Debug log]
TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample [Error message] [Debug log]
TestAccPubsubSubscription_pubsubSubscriptionTagsExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2026-04-17T15:35:02Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 17 files changed, 1436 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 15 files changed, 1426 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 257 insertions(+))

Missing service labels

The following new resources do not have corresponding service labels:

google_data_lineage_config

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Apr 10, 2026

github-actions bot requested a review from slevenick April 10, 2026 10:55

pawelmarut force-pushed the feature/datalineage-config branch 3 times, most recently from afd15cc to 6ae490b Compare April 13, 2026 09:38

pawelmarut force-pushed the feature/datalineage-config branch from 9157862 to dd3b07b Compare April 15, 2026 11:01

Create datalineage config provider

049dc90

pawelmarut force-pushed the feature/datalineage-config branch from dd3b07b to 049dc90 Compare April 15, 2026 12:50

github-actions bot requested review from malhotrasagar2212 and removed request for slevenick April 15, 2026 17:02

zli82016 requested review from zli82016 and removed request for malhotrasagar2212 April 15, 2026 17:56

modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Apr 15, 2026

zli82016 requested changes Apr 15, 2026

View reviewed changes

github-actions bot requested a review from zli82016 April 16, 2026 14:44

modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Apr 16, 2026

Code review comments

01395fa

modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Apr 17, 2026

Conversation

pawelmarut commented Apr 10, 2026

Uh oh!

google-cla bot commented Apr 10, 2026

Uh oh!

github-actions bot commented Apr 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 15, 2026

Uh oh!

zli82016 commented Apr 15, 2026

Uh oh!

zli82016 commented Apr 15, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

modular-magician commented Apr 15, 2026

Diff report

Missing service labels

Uh oh!

modular-magician commented Apr 15, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Apr 15, 2026

Uh oh!

pawelmarut commented Apr 16, 2026

Uh oh!

zli82016 commented Apr 16, 2026

Uh oh!

zli82016 commented Apr 16, 2026

Uh oh!

modular-magician commented Apr 16, 2026

Diff report

Missing service labels

Uh oh!

modular-magician commented Apr 16, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Apr 16, 2026

Uh oh!

modular-magician commented Apr 17, 2026

Diff report

Missing service labels

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Apr 10, 2026 •

edited

Loading