Skip to content

Migrated Compute router status to use transport_tpg.SendRequest #17070

Draft
jcromanu wants to merge 2 commits intoGoogleCloudPlatform:mainfrom
jcromanu:data_source_google_compute_router_status
Draft

Migrated Compute router status to use transport_tpg.SendRequest #17070
jcromanu wants to merge 2 commits intoGoogleCloudPlatform:mainfrom
jcromanu:data_source_google_compute_router_status

Conversation

@jcromanu
Copy link
Copy Markdown

@jcromanu jcromanu commented Apr 10, 2026

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: migrated `google_compute_router_status` data source to use direct HTTP rather than a client library

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Apr 10, 2026
@github-actions github-actions bot requested a review from c2thorn April 10, 2026 00:16
@github-actions
Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@jcromanu jcromanu changed the title Data source google compute router status Migrated Compute router status to use transport_tpg.SendRequest Apr 10, 2026
@slevenick slevenick requested review from slevenick and removed request for c2thorn April 10, 2026 17:02
@slevenick
Copy link
Copy Markdown
Contributor

/gcbrun

@modular-magician modular-magician added service/compute-router and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Apr 10, 2026
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 42 insertions(+), 24 deletions(-))
google-beta provider: Diff ( 1 file changed, 42 insertions(+), 24 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 1407
Passed tests: 1314
Skipped tests: 90
Affected tests: 3

Click here to see the affected service packages
  • compute

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeRouterPeer_AddMd5AuthenticationKey
  • TestAccComputeRouterPeer_UpdateMd5AuthenticationKey
  • TestAccDataSourceComputeRouterStatus

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccComputeRouterPeer_AddMd5AuthenticationKey [Debug log]
TestAccComputeRouterPeer_UpdateMd5AuthenticationKey [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccDataSourceComputeRouterStatus [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@jcromanu jcromanu force-pushed the data_source_google_compute_router_status branch from 85197b2 to 74c1e9e Compare April 10, 2026 21:23
@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Apr 10, 2026
@jcromanu jcromanu marked this pull request as draft April 14, 2026 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-approval Pull requests that need reviewer's approval to run presubmit tests service/compute-router

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants