Adding serviceAccountAuthConfig to google_dialogflow_cx_webhook;

[zhihaos]

dialogflowcx: added `serviceAccountAuthConfig ` field to `google_dialogflow_cx_webhook` resource

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 180 insertions(+))
google-beta provider: Diff ( 3 files changed, 180 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 66 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dialogflow_cx_webhook (10 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dialogflow_cx_webhook" "primary" {
  generic_web_service {
    service_account_auth_config {
      service_account = # value needed
    }
  }
  service_directory {
    generic_web_service {
      service_account_auth_config {
        service_account = # value needed
      }
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 46
Passed tests: 44
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

• dialogflowcx

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccDialogflowCXTestCase_dialogflowcxTestCaseFullExample
• TestAccDialogflowCXTestCase_update

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccDialogflowCXTestCase_dialogflowcxTestCaseFullExample [Error message] [Debug log]
TestAccDialogflowCXTestCase_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 276 insertions(+))
google-beta provider: Diff ( 4 files changed, 276 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 66 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dialogflow_cx_webhook (11 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dialogflow_cx_webhook" "primary" {
  service_directory {
    generic_web_service {
      service_account_auth_config {
        service_account = # value needed
      }
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 47
Passed tests: 44
Skipped tests: 0
Affected tests: 3

Click here to see the affected service packages

• dialogflowcx

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccDialogflowCXTestCase_dialogflowcxTestCaseFullExample
• TestAccDialogflowCXTestCase_update
• TestAccDialogflowCXWebhook_dialogflowcxWebhookServiceAccountAuthExample

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccDialogflowCXWebhook_dialogflowcxWebhookServiceAccountAuthExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode:
TestAccDialogflowCXTestCase_dialogflowcxTestCaseFullExample [Error message] [Debug log]
TestAccDialogflowCXTestCase_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 364 insertions(+))
google-beta provider: Diff ( 4 files changed, 364 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 66 insertions(+))

[modular-magician]

Tests analytics

Total tests: 48
Passed tests: 44
Skipped tests: 0
Affected tests: 4

Click here to see the affected service packages

• dialogflowcx

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccDialogflowCXTestCase_dialogflowcxTestCaseFullExample
• TestAccDialogflowCXTestCase_update
• TestAccDialogflowCXWebhook_dialogflowcxWebhookServiceDirectoryWithServiceAccountAuthExample
• TestAccDialogflowCXWebhook_dialogflowcxWebhookWithServiceAccountAuthExample

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccDialogflowCXWebhook_dialogflowcxWebhookWithServiceAccountAuthExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode:
TestAccDialogflowCXTestCase_dialogflowcxTestCaseFullExample [Error message] [Debug log]
TestAccDialogflowCXTestCase_update [Error message] [Debug log]
TestAccDialogflowCXWebhook_dialogflowcxWebhookServiceDirectoryWithServiceAccountAuthExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 366 insertions(+))
google-beta provider: Diff ( 4 files changed, 366 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 66 insertions(+))

[modular-magician]

Tests analytics

Total tests: 48
Passed tests: 45
Skipped tests: 0
Affected tests: 3

Click here to see the affected service packages

• dialogflowcx

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccDialogflowCXTestCase_dialogflowcxTestCaseFullExample
• TestAccDialogflowCXTestCase_update
• TestAccDialogflowCXWebhook_dialogflowcxWebhookServiceDirectoryWithServiceAccountAuthExample

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccDialogflowCXTestCase_dialogflowcxTestCaseFullExample [Error message] [Debug log]
TestAccDialogflowCXTestCase_update [Error message] [Debug log]
TestAccDialogflowCXWebhook_dialogflowcxWebhookServiceDirectoryWithServiceAccountAuthExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 366 insertions(+))
google-beta provider: Diff ( 4 files changed, 366 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 66 insertions(+))

[modular-magician]

Tests analytics

Total tests: 48
Passed tests: 45
Skipped tests: 0
Affected tests: 3

Click here to see the affected service packages

• dialogflowcx

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccDialogflowCXTestCase_dialogflowcxTestCaseFullExample
• TestAccDialogflowCXTestCase_update
• TestAccDialogflowCXWebhook_dialogflowcxWebhookServiceDirectoryWithServiceAccountAuthExample

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccDialogflowCXWebhook_dialogflowcxWebhookServiceDirectoryWithServiceAccountAuthExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode:
TestAccDialogflowCXTestCase_dialogflowcxTestCaseFullExample [Error message] [Debug log]
TestAccDialogflowCXTestCase_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[github-actions]

@c2thorn This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[zhihaos]

@c2thorn, hi Cameron, this is a customer escalation, do you have time to review it? Thanks!

[github-actions]

@GoogleCloudPlatform/terraform-team @c2thorn This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

[c2thorn]

/gcbrun

[c2thorn]

checking VCR recording results, we are trying to be more strict with merging failing tests. PR LGTM, just waiting on VCR confirmation.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 366 insertions(+))
google-beta provider: Diff ( 4 files changed, 366 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 66 insertions(+))

[modular-magician]

Tests analytics

Total tests: 48
Passed tests: 46
Skipped tests: 2
Affected tests: 0

Click here to see the affected service packages

• dialogflowcx

🟢 All tests passed!

View the build log

[c2thorn]

test rerun passed. LGTM