adds deletion_policy field generation to templates

[NickElliot]

PR 1 of hashicorp/terraform-provider-google#25072

Adds ability to generate a deletion policy field via an opt-in flag.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

[NickElliot]

Due to errors in #16076 from the size of the PR, swapping these generator changes to be done in product based batches. Following this PR I will bring the project flag into the swap PR, but maintain the need for it to be flagged true.

Once all the product directories are merged into the feature branch, I will remove the project flag and there should be no diffs in this feature branch.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 6 insertions(+))
google-beta provider: Diff ( 1 file changed, 6 insertions(+))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 6 insertions(+))
google-beta provider: Diff ( 1 file changed, 6 insertions(+))

[NickElliot]

brought the swap into this PR since it already has an opt-in gate via project, no reason for this change to be seperate due to the lack of diffs.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 6 insertions(+))
google-beta provider: Diff ( 1 file changed, 6 insertions(+))

[modular-magician]

🔴 The provider crashed while running the VCR tests in REPLAYING mode
Please fix it to complete your PR.
View the build log

[modular-magician]

🔴 The provider crashed while running the VCR tests in REPLAYING mode
Please fix it to complete your PR.
View the build log

[modular-magician]

🔴 The provider crashed while running the VCR tests in REPLAYING mode
Please fix it to complete your PR.
View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 5 insertions(+))
google-beta provider: Diff ( 1 file changed, 5 insertions(+))

[modular-magician]

Tests analytics

Total tests: 5987
Passed tests: 5339
Skipped tests: 633
Affected tests: 15

Click here to see the affected service packages

All service packages are affected

Action taken

Found 15 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccAccessContextManager__service_perimeter_dry_run_egress_policy
• TestAccAccessContextManager__service_perimeter_dry_run_ingress_policy
• TestAccComputeNetwork_bgpModeAndMedInteractions
• TestAccComputeNetwork_networkBgpStandardModeDeleteMed
• TestAccComputeNetwork_networkBgpStandardModeDeleteMedExample
• TestAccContainerCluster_autoprovisioningDefaultsManagement
• TestAccContainerCluster_autoprovisioningDefaultsUpgradeSettings
• TestAccContainerCluster_autoprovisioningLocations
• TestAccContainerCluster_nodeAutoprovisioning
• TestAccContainerCluster_nodeAutoprovisioningDefaults
• TestAccContainerCluster_nodeAutoprovisioningDefaultsDiskSizeGb
• TestAccContainerCluster_nodeAutoprovisioningDefaultsDiskType
• TestAccContainerCluster_withAutoscalingProfile
• TestAccContainerCluster_withDefaultComputeClassEnabled
• TestAccDiscoveryEngineSearchEngine_discoveryengineSearchengineBasicExample_update

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccAccessContextManager__access_level [Debug log]
TestAccAccessContextManager__access_level_condition [Debug log]
TestAccAccessContextManager__access_level_custom [Debug log]
TestAccAccessContextManager__access_level_full [Debug log]
TestAccAccessContextManager__access_levels [Debug log]
TestAccAccessContextManager__access_policy [Debug log]
TestAccAccessContextManager__access_policy_scoped [Debug log]
TestAccAccessContextManager__authorized_orgs_desc [Debug log]
TestAccAccessContextManager__service_perimeter [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_egress_policy [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_ingress_policy [Debug log]
TestAccAccessContextManager__service_perimeter_update [Debug log]
TestAccAccessContextManager__service_perimeters [Debug log]
TestAccComputeNetwork_bgpModeAndMedInteractions [Debug log]
TestAccComputeNetwork_networkBgpStandardModeDeleteMed [Debug log]
TestAccComputeNetwork_networkBgpStandardModeDeleteMedExample [Debug log]
TestAccContainerCluster_autoprovisioningDefaultsManagement [Debug log]
TestAccContainerCluster_autoprovisioningDefaultsUpgradeSettings [Debug log]
TestAccContainerCluster_autoprovisioningLocations [Debug log]
TestAccContainerCluster_nodeAutoprovisioning [Debug log]
TestAccContainerCluster_nodeAutoprovisioningDefaults [Debug log]
TestAccContainerCluster_nodeAutoprovisioningDefaultsDiskSizeGb [Debug log]
TestAccContainerCluster_nodeAutoprovisioningDefaultsDiskType [Debug log]
TestAccContainerCluster_withAutoscalingProfile [Debug log]
TestAccContainerCluster_withDefaultComputeClassEnabled [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccAccessContextManager__service_perimeter_dry_run_egress_policy [Error message] [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_ingress_policy [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

---

🔴 Tests failed during RECORDING mode:
TestAccDiscoveryEngineSearchEngine_discoveryengineSearchengineBasicExample_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[c2thorn]

LGTM, acknowledging interim flag states

[c2thorn]

There's no harm in adding appending this, even if there's no deletion_policy field? I guess that's what we are already doing for labels?

[NickElliot]

I don't believe so from the quick testing I did but I'll reverify toward the end. Worst case it does entail the excess of manual test updates.