Skip to content

partial success on event-exporter writing logs #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
snowhork wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −3
Open

partial success on event-exporter writing logs #475

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions event-exporter/sinks/stackdriver/writer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,10 @@ func newSdWriter(service *sd.Service) sdWriter {
// unless the API returns BadRequest error.
func (w sdWriterImpl) Write(entries []*sd.LogEntry, logName string, resource *sd.MonitoredResource) {
req := &sd.WriteLogEntriesRequest{
Entries: entries,
LogName: logName,
Resource: resource,
Entries: entries,
LogName: logName,
Resource: resource,
PartialSuccess: true,
Copy link
Member

@sophieliu15 sophieliu15 Jun 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending in the PR!

We also need to count how many entries are successfully delivered in our metrics here and their corresponding latency: https://github.com/GoogleCloudPlatform/k8s-stackdriver/blob/master/event-exporter/sinks/stackdriver/writer.go#L66-L67

If there is an easy way to count those, could you update corresponding metrics? If not, feel free to send us a feature request PR and we will prioritize the work based on our team capacity and priority.

Copy link
Author

@snowhork snowhork Jun 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sophieliu15 Thanks for your reply! I will try it.

}

// We retry forever, until request either succeeds or API returns
Expand Down