Remove Dependabot auto-merge workflow#1140
Merged
erain merged 1 commit intoGoogleCloudPlatform:masterfrom Mar 24, 2026
Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This change removes the auto-merge functionality for Dependabot PRs that was introduced in PR GoogleCloudPlatform#1035. While the original intent was to reduce manual toil for routine dependency updates, automatic merging has proven to be risky for this repository. The auto-merge workflow only considered semantic versioning (patch and minor updates), but this is insufficient for Kubernetes-related dependencies where minor version bumps can introduce breaking API changes. For example, commit 13a30c1 updated k8s.io/apiserver from 0.33.1 to 0.35.2, which was classified as a minor update but actually contained breaking changes that could affect compatibility. After this change, all Dependabot PRs will require manual review and approval before merging, ensuring that maintainers can properly assess the risk of each dependency update.
erain
force-pushed
the
disable-dependabot-auto-merge
branch
from
412835b to
5e62b96
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the auto-merge functionality for Dependabot PRs that was introduced in #1035.
Rationale
While the original intent of auto-merge was to reduce manual toil for routine dependency updates, automatic merging has proven to be risky for this repository.
The Problem
The auto-merge workflow only considered semantic versioning classifications (patch and minor updates) when deciding whether to auto-merge:
However, this is insufficient for Kubernetes-related dependencies where "minor" version bumps can introduce breaking API changes.
Real-world Example
A recent auto-merged commit (
13a30c12) updatedk8s.io/apiserverfrom0.33.1to0.35.2.This was classified as a "version-update:semver-minor" update, but:
Proposed Change
Remove the
.github/workflows/dependabot-auto-merge.yamlworkflow entirely. After this change:Related
13a30c12