make ExternalMetricsRequestWindow configurable#1117
Open
tav-pw wants to merge 1 commit intoGoogleCloudPlatform:masterfrom
Open
make ExternalMetricsRequestWindow configurable#1117tav-pw wants to merge 1 commit intoGoogleCloudPlatform:masterfrom
tav-pw wants to merge 1 commit intoGoogleCloudPlatform:masterfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add configurable
--external-metrics-request-windowflagSummary
Add a
--external-metrics-request-windowflag to make the Cloud Monitoring query window configurable. Currently hardcoded to 5 minutes, which causes HPAs to receive no metrics when using sparse metrics (e.g. exported every 10 minutes).Problem
The adapter queries Cloud Monitoring with a fixed 5-minute window (
[now - 5 min, now]). Metrics exported less frequently often fall outside this window, so the External Metrics API returns empty and HPAs cannot scale.Relevant code:
startTime := endTime.Add(-t.reqWindow))Solution
Add a configurable flag with default
5mfor backward compatibility. Users with sparse metrics can set--external-metrics-request-window=1h(or similar).Changes
ExternalMetricsRequestWindow time.DurationtostackdriverAdapterServerOptions5*time.MinuteinserverOptionsflags.DurationVarfor--external-metrics-request-windowserverOptions.ExternalMetricsRequestWindowtomakeProviderOrDieinstead of5*time.MinuteTesting
--external-metrics-request-window=1h, sparse metrics should be returned reliably