fix: return 400 for malformed path encoding#754
Open
IzaakGough wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
Open
fix: return 400 for malformed path encoding#754IzaakGough wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
IzaakGough wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When the request path contains invalid percent-encoding (for example an incomplete sequence like
%C3),decodeURIComponentthrows and that error can surface as 500. This change responds with 400 Bad Request instead, before the user function runs.Context: firebase/firebase-functions#1646 — malformed paths have been reported as internal errors and noisy logs for HTTP / Cloud Functions workloads built on this framework.
Changes
server.ts— Early middleware validates the path segment ofreq.urlwithdecodeURIComponentin atry/catch. On failure, respond with 400 and a short body; do not invoke the user function.test/integration/http.ts— Integration testGET with non UTF-8 encoded chars(path/%C3): 400 and handler not called (callCountunchanged).Testing
Automated
GET with non UTF-8 encoded chars: status 400, empty body (same shape as other non-JSON cases),callCount === 0.npm test(afternpm run compileif needed) passes.Manual