This repository was archived by the owner on May 8, 2025. It is now read-only.
Introduce CRD v1: fix CRD generation bugs and enable field validation#436
Open
elanv wants to merge 4 commits intoGoogleCloudPlatform:masterfrom
Open
Introduce CRD v1: fix CRD generation bugs and enable field validation#436elanv wants to merge 4 commits intoGoogleCloudPlatform:masterfrom
elanv wants to merge 4 commits intoGoogleCloudPlatform:masterfrom
Conversation
elanv
changed the title
|
Thanks for the fix! @functicons @hongyegong Is there anything blocking merging this PR? Looks like the tests are blocked on someone approving the tests to run? |
This was referenced Jul 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces CRD v1.
CRD v1 is supported in Kubernetes version 1.16+.
Note
There is a known issue(Restricted CRD API group "k8s.io" #382) for introducing CRD v1. For now, applied a workaround marking the CRD annotation
api-approved.kubernetes.ioasunapproved. Unapproved domain use is still a remaning issue.Descrition
Now can use kubebuilder validation markers that can partially replace the functions of default/validating webhooks and their test codes.
https://book.kubebuilder.io/reference/markers/crd-validation.html