feat(spanner): Improve and extend support for Spanner Client#247
Open
aseering wants to merge 2 commits intoGoogleCloudPlatform:mainfrom
Open
feat(spanner): Improve and extend support for Spanner Client#247aseering wants to merge 2 commits intoGoogleCloudPlatform:mainfrom
aseering wants to merge 2 commits intoGoogleCloudPlatform:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Replaces the SQLAlchemy-based implementation with a native Google Cloud Spanner client to improve stability and support for PostgreSQL dialects. - Implements native and using queries. - Adds robust with multi-pass retry logic for Foreign Key cycles and proper quoting for case-sensitive Postgres tables. - Implements high-performance using the Mutation API with type-aware processing. - Adds support for .
- Updates SQLGenBasePromptGenerator to detect Spanner dialect (GoogleSQL vs PostgreSQL) from db config. - Adds specific prompt templates for Spanner GoogleSQL (using backticks) and Spanner PostgreSQL (using quotes).
474ad8d to
2c8df8a
Compare
IsmailMehdi
reviewed
Feb 23, 2026
Collaborator
IsmailMehdi
left a comment
There was a problem hiding this comment.
it would be good to have a run config that showcases the emulator.
IsmailMehdi
reviewed
Feb 23, 2026
Collaborator
IsmailMehdi
left a comment
There was a problem hiding this comment.
please take a look at the style issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend the Spanner Client to be more robust and more featureful.