Add configurable start timeout#136
Open
Haihan-Jiang wants to merge 1 commit into
Open
Conversation
Author
|
This is ready for review. The change adds a configurable start timeout for local Composer startup flows, and the visible checks are green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #108
This adds a
--start-timeout SECONDSoption forcomposer-dev startandcomposer-dev restart. The default behavior remains 300 seconds, and--start-timeout 0disables the timeout for cases where dependency installation needs to run longer.Changes:
Tested:
python -m pytest tests/unit/test_cli.py::TestStartRestartCommand tests/unit/test_environment.py::TestWaitForStart -qpython -m pytest tests/unit -qpython -m black --check composer_local_dev tests/unit