gke-deploy: get deployed objects from manifests#1106
Open
Haihan-Jiang wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Change
gke-deploy's readiness polling to fetch deployed objects withkubectl get -f -using the original manifest, instead of fetching by onlykindandname.Why
When a cluster has multiple CRDs with the same Kind in different API groups,
kubectl get <kind> <name>can resolve the wrong resource. This causedgke-deployto wait oningressroutes.traefik.containo.useven when the applied manifest declaredapiVersion: traefik.io/v1alpha1.Using the manifest for the get operation preserves the resource's declared
apiVersionandkind, matching the object that was applied.Fixes #962.
Validation
cd gke-deploy && go test ./core/cluster ./deployer ./services ./testservicescd gke-deploy && go test ./...IngressRoutemanifest usingapiVersion: traefik.io/v1alpha1and a test kubectl response that must be consumed through the manifest-based get path.