fix(mvn): provide python command in appengine image#1105
Open
Haihan-Jiang wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Install
python-is-python3in themvn:appenginebuilder image so scripts that invokepythonresolve to Python 3.Why
The App Engine Maven plugin downloads and installs the Google Cloud SDK. Recent SDK installation paths still invoke
python, while the current image only installspython3. That causesmvn:appenginebuilds to fail withpython: command not found.Fixes #1056.
Validation
git diff --checkpython3 python-is-python3and then exposes both commands:command -v python->/usr/bin/pythonpython --version->Python 3.10.12command -v python3->/usr/bin/python3python3 --version->Python 3.10.12docker build -f mvn/Dockerfile.appengine ...; it passed the previouspython: command not foundfailure point and reachedgcloud components install app-engine-java. I stopped it later during Cloud SDK post-processing because this local Mac was running the amd64 image under arm64 emulation.