gke-deploy: apply existing Namespace configs#1102
Open
Haihan-Jiang wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #873.
gke-deploy applycurrently handles Namespace objects specially: it checks whether each Namespace already exists, creates it if missing, and then removes Namespace objects from the normal apply list. That means existing Namespace objects are never applied again, so changes such as new labels in the manifest are silently skipped.This change keeps the existing create-warning behavior for missing namespaces, but always applies the Namespace manifest. Existing namespaces can then be updated by
kubectl apply, matching the behavior users expect from applying the same YAML with kubectl directly. Namespace objects are still excluded from the deployment summary.Validation:
go test ./deployer ./core/cluster ./core/resourcefromgke-deploygo test ./...fromgke-deploygit diff --check