fix: remove sameParty Cookie attribute #3970
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chrome never shipped support for HTTP Set-Cookie directive and Cookie.sameParty APIs. This commit removes code for mapping Cookie.sameParty values which were never fully supported.
bershanskiy
had a problem deploying
to
github-pages
GitHub Actions
Failure
sadym-chromium
approved these changes
Jan 8, 2026
Collaborator
sadym-chromium
left a comment
sadym-chromium
left a comment
There was a problem hiding this comment.
Please deprecate the Puppeteer's sameParty as well.
This was referenced Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chrome never shipped support for HTTP Set-Cookie directive and Cookie.sameParty APIs. This commit removes code for mapping
Cookie.samePartyvalues which were never fully supported.Background
SamePartycookie attribute (in all contexts, including HTTP Set-Cookie header and all JS APIs).samePartyattributes fromCookieandCookieInitJS APIs and setting corresponding internal Boolean tofalse(diff).samePartyand in tests remarked that miraculouslysamePartyis not set for whatever reason.