Open
Conversation
OrKoN
force-pushed
the
orkon/loading-failed
branch
from
68d3a9e to
efac0d1
Compare
OrKoN
added
puppeteer
Lightning00Blade
approved these changes
Oct 13, 2025
Collaborator
Author
|
This PR cannot be landed because it would only emit responseCompleted for network requests that were consumed which might be according to the spec but currently fails some Puppeteer tests. Probably depends on fixing puppeteer/puppeteer#14315 first |
OrKoN
force-pushed
the
orkon/loading-failed
branch
from
efac0d1 to
fafed54
Compare
Lightning00Blade
approved these changes
Dec 10, 2025
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark
Details
| Benchmark suite | Current: d906cc1 | Previous: 4184afc | Ratio |
|---|---|---|---|
ubuntu-latest-new-headless-node:test_performance_screenshot |
156.1389446258545 ms |
137.89057731628418 ms |
1.13 |
macos-latest-new-headless-cd:test_performance_screenshot |
2892.750597000122 ms |
2487.3996257781982 ms |
1.16 |
macos-latest-headful-node:test_performance_screenshot |
2039.85481262207 ms |
2778.6727905273438 ms |
0.73 |
macos-latest-headful-cd:test_performance_screenshot |
3262.034034729004 ms |
1890.6847953796387 ms |
1.73 |
ubuntu-latest-old-headless-node:test_performance_screenshot |
268.94264221191406 ms |
252.52380371093753 ms |
1.07 |
macos-latest-old-headless-cd:test_performance_screenshot |
236.11798286437988 ms |
265.80657958984375 ms |
0.89 |
macos-latest-old-headless-node:test_performance_screenshot |
256.19964599609375 ms |
226.79271697998047 ms |
1.13 |
ubuntu-latest-new-headless-cd:test_performance_screenshot |
178.29489707946777 ms |
177.354097366333 ms |
1.01 |
ubuntu-latest-old-headless-cd:test_performance_screenshot |
268.0319309234619 ms |
272.5314140319824 ms |
0.98 |
ubuntu-latest-headful-node:test_performance_screenshot |
169.14963722229004 ms |
This comment was automatically generated by workflow using github-action-benchmark.
Collaborator
sadym-chromium
left a comment
sadym-chromium
left a comment
There was a problem hiding this comment.
Is the description accurate?
sadym-chromium
temporarily deployed
to
github-pages
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3574