test: e2e test on *.test domains#3448
Draft
sadym-chromium wants to merge 14 commits intomainfrom
Draft
Conversation
sadym-chromium
changed the title
e2e test on test domains
sadym-chromium
force-pushed
the
sadym/local_server_2
branch
from
2561228 to
9898609
Compare
sadym-chromium
changed the title
e2e test on test domainse2e test on .*test domains
sadym-chromium
changed the title
e2e test on .*test domainse2e test on *.test domains
sadym-chromium
force-pushed
the
sadym/local_server_2
branch
from
6ca438b to
04b6ee8
Compare
sadym-chromium
force-pushed
the
sadym/local_server_2
branch
2 times, most recently
from
fef4f93 to
363d4b3
Compare
Instead of testing on `localhost`, provide `--host-resolver-rules` arg to Chrome and test on `*.test` domains.
# Conflicts: # tests/network/test_network.py
sadym-chromium
force-pushed
the
sadym/local_server_2
branch
from
363d4b3 to
74b3d6a
Compare
sadym-chromium
force-pushed
the
sadym/local_server_2
branch
from
f452676 to
db1c6c1
Compare
Collaborator
|
@sadym-chromium does it need a review? |
Collaborator
Author
It needs to be fixed first |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing #2771.
Use
--host-resolver-rulesargument to run e2e tests with some test domains instead oflocalhost,127.0.0.1etc.Plus, rename
local_server_httptolocal_http_server.