Trickle ICE #456
Open
Trickle ICE #456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nab-os
force-pushed
the
trickle_ice_wip
branch
from
ac2cd53 to
b968bf8
Compare
Collaborator
|
Nice this LGTM @nab-os! I am going to add support in frontend (unless you have interest/time to do it yourself!) Thanks for doing this :) |
Sean-Der
reviewed
Dec 5, 2025
| streamMapLock sync.Mutex | ||
| apiWhip, apiWhep *webrtc.API | ||
| streamMap map[string]*stream | ||
| peerConnectionMap map[string]*webrtc.PeerConnection |
Collaborator
There was a problem hiding this comment.
Do we need peerConnectionMap
Would it be possible to walk the existing streamMap? I am worried duplicated state will lead to bugs
Author
There was a problem hiding this comment.
Yes we need it, but I think we could extract the stream from the peerConnection.
I'm gonna look into having only one map but maybe it's out of scope for the PR ?
Author
|
I'll let you work out the frontend if you are willing to do it. |
Author
|
Oh, I must update the tests too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowing post-offer ice negotiation via Trickle ICE
Tested on a local setup with meetecho/simple-whip-client