Chore/update codeql cli 2.24.3 - fix failing tests#180
Conversation
- java/src/library_sources/ExternalAPIs.qll: rename applyManualModel() to hasManualModel() on SummarizedCallable (method was removed in java-all 8.1.1) - python/lib/ghsl/MassAssignment.qll: replace deprecated Value type and CallNode with DataFlow::MethodCallNode (Value is no longer re-exported from python.qll in python-all 7.0.0) Co-authored-by: felickz <1760475+felickz@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Updates this repository’s CodeQL CLI pin and aligns the community packs’ declared dependencies/locks with the newer CodeQL library set, including a couple of small QL source updates needed for compatibility.
Changes:
- Bump pinned CodeQL CLI version to
2.24.3and release version to0.5.0. - Update language pack
qlpack.ymldependencies andcodeql-pack.lock.ymllockfiles across Ruby, Python, JavaScript, Java, Go, C#, and C++. - Adjust QL code in Python (
MassAssignment.qll) and Java (ExternalAPIs.qll) to match updated library APIs.
Show a summary per file
| File | Description |
|---|---|
| ruby/test/qlpack.yml | Bumps Ruby test pack dependencies. |
| ruby/test/codeql-pack.lock.yml | Updates Ruby test pack dependency lock versions. |
| ruby/src/qlpack.yml | Bumps Ruby queries pack version/dependency. |
| ruby/src/codeql-pack.lock.yml | Updates Ruby queries pack dependency lock versions. |
| ruby/lib/qlpack.yml | Bumps Ruby libs pack version/dependency. |
| ruby/lib/codeql-pack.lock.yml | Updates Ruby libs pack dependency lock versions. |
| python/test/qlpack.yml | Bumps Python test pack dependencies. |
| python/test/codeql-pack.lock.yml | Updates Python test pack dependency lock versions. |
| python/src/qlpack.yml | Bumps Python queries pack version/dependency. |
| python/src/codeql-pack.lock.yml | Updates Python queries pack dependency lock versions. |
| python/lib/qlpack.yml | Bumps Python libs pack version/dependency. |
| python/lib/ghsl/MassAssignment.qll | Updates call matching logic for __setattr__ to newer dataflow API. |
| python/lib/codeql-pack.lock.yml | Updates Python libs pack dependency lock versions. |
| python/ext/qlpack.yml | Bumps Python extensions pack version/target dependency. |
| javascript/test/qlpack.yml | Bumps JavaScript test pack dependency. |
| javascript/test/codeql-pack.lock.yml | Updates JavaScript test pack dependency lock versions. |
| javascript/src/qlpack.yml | Bumps JavaScript queries pack version/dependency. |
| javascript/src/codeql-pack.lock.yml | Updates JavaScript queries pack dependency lock versions. |
| javascript/lib/qlpack.yml | Bumps JavaScript libs pack version/dependency. |
| javascript/lib/codeql-pack.lock.yml | Updates JavaScript libs pack dependency lock versions. |
| java/test/qlpack.yml | Bumps Java test pack dependency. |
| java/test/codeql-pack.lock.yml | Updates Java test pack dependency lock versions. |
| java/src/qlpack.yml | Bumps Java queries pack version/dependency. |
| java/src/library_sources/ExternalAPIs.qll | Updates manual-model detection to newer FlowSummary API. |
| java/src/codeql-pack.lock.yml | Updates Java queries pack dependency lock versions. |
| java/lib/qlpack.yml | Bumps Java libs pack version/dependency. |
| java/lib/codeql-pack.lock.yml | Updates Java libs pack dependency lock versions. |
| java/ext/qlpack.yml | Bumps Java extensions pack version/target dependency. |
| java/ext-library-sources/qlpack.yml | Bumps Java library-sources pack version/target dependency. |
| go/test/qlpack.yml | Bumps Go test pack dependency. |
| go/test/codeql-pack.lock.yml | Updates Go test pack dependency lock versions. |
| go/src/qlpack.yml | Bumps Go queries pack version/dependency. |
| go/src/codeql-pack.lock.yml | Updates Go queries pack dependency lock versions. |
| go/lib/qlpack.yml | Bumps Go libs pack version/dependency. |
| go/lib/codeql-pack.lock.yml | Updates Go libs pack dependency lock versions. |
| go/ext/qlpack.yml | Bumps Go extensions pack version/target dependency. |
| csharp/test/qlpack.yml | Bumps C# test pack dependencies. |
| csharp/test/codeql-pack.lock.yml | Updates C# test pack dependency lock versions. |
| csharp/src/qlpack.yml | Bumps C# queries pack version/dependencies. |
| csharp/src/codeql-pack.lock.yml | Updates C# queries pack dependency lock versions. |
| csharp/lib/qlpack.yml | Bumps C# libs pack version/dependency. |
| csharp/lib/codeql-pack.lock.yml | Updates C# libs pack dependency lock versions. |
| csharp/ext/qlpack.yml | Bumps C# extensions pack version/target dependency. |
| csharp/ext-library-sources/qlpack.yml | Bumps C# library-sources pack version/target dependency. |
| cpp/test/qlpack.yml | Bumps C++ test pack dependencies. |
| cpp/test/codeql-pack.lock.yml | Updates C++ test pack dependency lock versions. |
| cpp/src/qlpack.yml | Bumps C++ queries pack version/dependencies. |
| cpp/src/codeql-pack.lock.yml | Updates C++ queries pack dependency lock versions. |
| cpp/lib/qlpack.yml | Bumps C++ libs pack version/dependency. |
| cpp/lib/codeql-pack.lock.yml | Updates C++ libs pack dependency lock versions. |
| .release.yml | Bumps overall release version to 0.5.0. |
| .codeqlversion | Pins CodeQL CLI version to 2.24.3. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 52/52 changed files
- Comments generated: 0
- Review effort level: Low
|
@copilot there are a few failing tests for java .. can you fix them? at least these say failing: 13 tests passed; 1 tests failed: Completed in 17m29s (extract 1m29s comp 14m14s eval 1m1s). 12 tests passed; 2 tests failed: |
Co-authored-by: felickz <1760475+felickz@users.noreply.github.com>
Fixed in commit I pulled failures from the validate step logs for run
Re-ran the four tests locally and they all pass. |
|
This pull request includes a version bump for the release configuration and several updates to expected test output files, primarily to reflect deprecation warnings and to clean up redundant or outdated entries. The changes also remove deprecated or unnecessary taint tracking and provenance edges from the
SpringUrlRedirecttest, simplifying the test output.Release configuration:
.release.ymlto bump the version from0.5.0to0.5.1.Test output updates:
JxBrowserWithoutCertValidation.expectedandLoadClassNoSignatureCheck.expectedtest files. [1] [2] [3]SpringUrlRedirect.expectedto reflect code or model changes. [1] [2] [3]#selectentries inLoadClassNoSignatureCheck.expected.