Feedback dialog submits to non-existent server endpoint#1
Open
Feedback dialog submits to non-existent server endpoint#1
Conversation
The FeedbackDialog component was submitting to a non-existent /feedback endpoint, causing every submission to silently fail with a 404. - Add feedback_entries table to server database schema with userId, message, images (jsonb), and createdAt columns - Create POST /feedback route with Bearer token auth validation (same pattern as /metrics/events) and input validation - Register the feedback route in the server entry point - Frontend already handles success (closes dialog) and error (displays message) states correctly; no changes needed Note: run `drizzle-kit generate` to create the migration for the new feedback_entries table. SUSTN-Task: b7b1101d-232f-4413-a917-151473ca5109
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUSTN Auto-PR
The feedback feature is wired end-to-end in the frontend — there's a
FeedbackDialogcomponent (src/ui/components/sidebar/FeedbackDialog.tsx) that lets users write feedback and attach screenshots, and auseFeedbackhook (src/core/api/useFeedback.ts:34) that POSTs to${config.authServerUrl}/feedback. But the server (server/src/index.ts) only registers three route groups:/auth,/health, and/metrics. There is no/feedbackroute. Every feedback submission silently fails with a 404.This is a broken user-facing feature — users can open the dialog, type feedback, and hit send, only for it to disappear into the void with no error feedback.
To fix:
feedbacktable to the server database schema (server/src/db/schema.ts) with columns for userId, message, category/type, and optional image data.POST /feedbackroute inserver/src/routes/that validates the auth token (same pattern as metrics), validates input, and inserts the feedback.server/src/index.ts.Branch:
feedback-dialog-submits-to-non-existent-server-endpoint