Fix items not displaying on brushable blocks #6089
Open
+9
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where items were not displaying correctly on brushable blocks (suspicious sand/gravel) in Bedrock Edition. The fix addresses NBT format changes in Java Edition and adds a required block type field for Bedrock.
- Updated NBT tag access to use the correct field name and data type ("count" as int instead of "Count" as byte)
- Added a "type" field to the Bedrock NBT that specifies the brushable block type
- Updated copyright year to 2026
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...n/java/org/geysermc/geyser/translator/level/block/entity/BrushableBlockEntityTranslator.java
Outdated
Show resolved
Hide resolved
onebeastchris
requested changes
Jan 7, 2026
...n/java/org/geysermc/geyser/translator/level/block/entity/BrushableBlockEntityTranslator.java
Show resolved
Hide resolved
...n/java/org/geysermc/geyser/translator/level/block/entity/BrushableBlockEntityTranslator.java
Outdated
Show resolved
Hide resolved
onebeastchris
approved these changes
Jan 8, 2026
| if (identifier == null) { | ||
| identifier = blockState.block().javaIdentifier().value(); | ||
| } | ||
| bedrockNbt.putString("type", identifier); |
Member
There was a problem hiding this comment.
How does the client handle weird types? e.g. sending "minecraft:glass" for some reason?
Malformed blockentity nbt is a thing, would be lovely if we'd have a safeguard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bedrock now seems to require this new
typefield in the NBT which seems to always be equal to the block you are brushing, without this field the brushed item doesn't show.