Refactor the collision system, various improvements to how collision fixes is handle, more fixes (again).#5836
Merged
onebeastchris merged 17 commits intomasterfrom Jan 22, 2026
Merged
Conversation
* Revert last change, move everything to a different package, added end portal fix. * Oops. * Fixed lantern collision. * Fixed conduit collision. * Fixed scaffolding collision. * Fixed bell collision and sea pickle collision. * Avoid loop. * oops. * oops x2. * Change comments.
* Revert last change, move everything to a different package, added end portal fix. * Oops. * Fixed lantern collision. * Fixed conduit collision. * Fixed scaffolding collision. * Fixed bell collision and sea pickle collision. * Avoid loop. * oops. * oops x2. * Change comments.
…/GeyserMC/Geyser into movement-translation-improvement
Member
|
I wonder if the collision fix for trap doors fixes #2951? Let me know once this is ready for review & I'll do testing on my end |
Collaborator
Author
Nope it won't since as of now we're doing Edit: Can't reproducible as of latest also. |
Collaborator
Author
|
I don't know what else to check for and add so I guess this PR is ready for review. |
onebeastchris
approved these changes
Jan 20, 2026
…xes/ChestCollision.java Co-authored-by: chris <github@onechris.mozmail.com>
…xes/ScaffoldingCollision.java Co-authored-by: chris <github@onechris.mozmail.com>
…xes/ChestCollision.java Co-authored-by: chris <github@onechris.mozmail.com>
…xes/SeaPickleCollision.java Co-authored-by: chris <github@onechris.mozmail.com>
…xes/ScaffoldingCollision.java Co-authored-by: chris <github@onechris.mozmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my second attempt, since I screw up the last one :) yay! so.
Changes:
correctPosition, since this caused many issues (already discuss in Discord).correctPosition, make it little bit more readable.correctPositionnow no longer return true/false, as in the original code this method always return true.Edit: resolve #2819, according to someone on discord :P