Skip to content

Change cakes, armor stand stack size to match JE, make fireworks rocket boosting server controlled.#5673

Merged
onebeastchris merged 10 commits intoGeyserMC:masterfrom
oryxel1:stack-fix
Mar 6, 2026
Merged

Change cakes, armor stand stack size to match JE, make fireworks rocket boosting server controlled.#5673
onebeastchris merged 10 commits intoGeyserMC:masterfrom
oryxel1:stack-fix

Conversation

@oryxel1
Copy link
Copy Markdown
Collaborator

@oryxel1 oryxel1 commented Jul 11, 2025

Does what it said, resolve: #5612 and resolve #4905 and resolve #5409, and resolve #5008.

For cake, it's just simply add some component to tell bedrock that stack size should be 1.
For armor stand, since componentBased is false I have to make it data driven so I can force the item to have max stack size to be 16.

Turn out by doing the same trick that we use with armor stand, we can make it so that now when player right clicking fireworks it won't boost so we can control it server sided.

@oryxel1 oryxel1 changed the title Change certain bedrock item stack size to match JE. Change cakes, armor stand stack size to match JE, make fireworks rocket boosting server controlled. Jul 11, 2025
Comment thread core/src/main/java/org/geysermc/geyser/item/type/FireworkRocketItem.java Outdated
Copy link
Copy Markdown
Member

@onebeastchris onebeastchris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty neat, even though this screams unintended behaviour, hehe

Might be worth it to wait untile eclipse's tooltip PR to fully handle e.g. firework rockets there without modifying the session?

Comment thread core/src/main/java/org/geysermc/geyser/session/GeyserSession.java Outdated
@onebeastchris onebeastchris merged commit bf93cc3 into GeyserMC:master Mar 6, 2026
2 checks passed
@oryxel1 oryxel1 deleted the stack-fix branch April 1, 2026 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants