feat(samples): device switcher lobby - #1311
Draft
renefloor wants to merge 4 commits into
Draft
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## v2 #1311 +/- ##
=====================================
Coverage ? 18.99%
=====================================
Files ? 341
Lines ? 26876
Branches ? 0
=====================================
Hits ? 5106
Misses ? 21770
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
renefloor
marked this pull request as draft
August 21, 2026 14:04
Contributor
Author
|
Converted to draft as the button specs changed: https://www.figma.com/design/W7pOBtNINkAh14XdCJQKuB/Video-SDK-Design?node-id=411-27303&m=dev#1894859878 |
The lobby pickers were outline buttons, which gave them pill corners and the button's hover treatment. Design has since specified a dedicated `Web / Select Input`, and the lobby uses it for exactly these two fields. Adds a dogfooding-local StreamSelectInput: the field only, so one field can still drive two selections the way the audio field picks a microphone and a speaker from a single menu. Density follows StreamTextInput rather than the denser web spec, so a select and a text input line up in a form. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
StreamSelectInput, StreamContextMenuAnchor, StreamContextMenuHeading and StreamRadioIndicator implement design-system components that stream_core_flutter does not ship yet. They were dogfooding-local; move them to src/widgets/design_system_candidates so the SDK and every sample can use them, and so there is one obvious place to lift them out of when they graduate to core. They now depend on stream_core_flutter directly rather than on the video barrel, and the select input gets a widget test covering its border and ring states, which cannot be exercised from the running app. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Fixes FLU-716
Make the device control selection closer to design: https://www.figma.com/design/W7pOBtNINkAh14XdCJQKuB/Video-SDK-Design?node-id=408-42575&m=dev
🛠 Implementation details
I've updated the call controls in the lobby screen.
On purpose I did not move anything to the SDK yet. The
StreamRadioIndicatorand theStreamContextMenuAnchorare candidates for core. TheLobbyDeviceControlscan move to the stream_video_flutter sdk. We should do that when we finalize the complete new lobby component.Also out of scope is the mic volume as that needs webrtc changes, see FLU-714
🎨 UI Changes
Add relevant screenshots