chore(llc): migrate to TokenManager from core [V2] - #1308
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
renefloor
left a comment
There was a problem hiding this comment.
Splitting the earlier review into inline comments — same findings, nits dropped. Three I'd want addressed before merge (core pin, guest token expiry, peekToken() mid-refresh); the rest are smaller. Nice cleanup otherwise — good to see the duplicated TokenManager/TokenProvider go, and the guest profile-fields and anonymous-token fixes are welcome.
renefloor
left a comment
There was a problem hiding this comment.
Two follow-ups on the token path, plus one still-open item on the core pin.
renefloor
left a comment
There was a problem hiding this comment.
One follow-up on the new refresh guard.
No description provided.