Skip to content

chore(llc): migrate to TokenManager from core [V2] - #1308

Open
Brazol wants to merge 11 commits into
v2from
chore/migrate-to-core-token-manager
Open

chore(llc): migrate to TokenManager from core [V2]#1308
Brazol wants to merge 11 commits into
v2from
chore/migrate-to-core-token-manager

Conversation

@Brazol

@Brazol Brazol commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@Brazol
Brazol requested a review from a team as a code owner August 18, 2026 11:19
@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: b20044b2-bf5f-4cc8-9f1c-03fbe75b9f59

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Brazol Brazol changed the title chore(llc): migrate to TokenManager from core chore(llc): migrate to TokenManager from core [V2] Aug 18, 2026
@codecov

codecov Bot commented Aug 18, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 61.13990% with 75 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (v2@f3fd83d). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...o/lib/src/coordinator/open_api/coordinator_ws.dart 0.00% 23 Missing ⚠️
packages/stream_video/lib/src/stream_video.dart 36.36% 14 Missing ⚠️
packages/stream_video/lib/src/sfu/ws/sfu_ws.dart 21.42% 11 Missing ⚠️
...ordinator/models/coordinator_connection_state.dart 0.00% 6 Missing ⚠️
...lib/src/coordinator/models/coordinator_events.dart 0.00% 6 Missing ⚠️
...ckages/stream_video/lib/src/logger/logger_api.dart 53.84% 6 Missing ⚠️
...ackages/stream_video/lib/src/call/call_events.dart 0.00% 2 Missing ⚠️
...rdinator/open_api/coordinator_client_open_api.dart 0.00% 2 Missing ⚠️
...s/stream_video/lib/src/logger/core_log_bridge.dart 92.59% 2 Missing ⚠️
...m_video/lib/src/token/token_manager_extension.dart 83.33% 2 Missing ⚠️
... and 1 more
Additional details and impacted files
@@          Coverage Diff          @@
##             v2    #1308   +/-   ##
=====================================
  Coverage      ?   19.24%           
=====================================
  Files         ?      339           
  Lines         ?    26805           
  Branches      ?        0           
=====================================
  Hits          ?     5159           
  Misses        ?    21646           
  Partials      ?        0           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

renefloor

This comment was marked as outdated.

@renefloor renefloor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Splitting the earlier review into inline comments — same findings, nits dropped. Three I'd want addressed before merge (core pin, guest token expiry, peekToken() mid-refresh); the rest are smaller. Nice cleanup otherwise — good to see the duplicated TokenManager/TokenProvider go, and the guest profile-fields and anonymous-token fixes are welcome.

Comment thread pubspec.yaml Outdated
Comment thread packages/stream_video/lib/src/stream_video.dart Outdated
Comment thread packages/stream_video/lib/src/stream_video.dart Outdated
Comment thread packages/stream_video/lib/src/stream_video.dart Outdated
Comment thread packages/stream_video/test/src/retry/rpc_retry_manager_test.dart
Comment thread packages/stream_video/test/src/retry/rpc_retry_manager_test.dart Outdated
Comment thread packages/stream_video/CHANGELOG.md Outdated
Comment thread packages/stream_video/CHANGELOG.md Outdated
Comment thread packages/stream_video/lib/src/token/token.dart Outdated
Comment thread packages/stream_video/lib/src/stream_video.dart Outdated

@renefloor renefloor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two follow-ups on the token path, plus one still-open item on the core pin.

Comment thread packages/stream_video/lib/src/stream_video.dart Outdated
Comment thread packages/stream_video/lib/src/coordinator/open_api/coordinator_ws.dart Outdated

@renefloor renefloor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One follow-up on the new refresh guard.

Comment thread packages/stream_video/lib/src/coordinator/open_api/coordinator_ws.dart Outdated
@Brazol
Brazol requested review from renefloor and xsahil03x August 26, 2026 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants