Open
Conversation
When the system launches CallService (e.g. from a push notification or process restart), AndroidThreeTen may not be initialized since StreamVideoBuilder.build() hasn't run yet. This causes a ZoneRulesException crash on OffsetDateTime.now() in onCreate. Since the only purpose is measuring elapsed service uptime for the stop debouncer, replace OffsetDateTime with SystemClock.elapsedRealtime() which is monotonic, requires no initialization, and is unaffected by wall clock changes.
* fix: Reject current active call when telecom puts it to inactive or hold * chore: improve code semantic
* feat: Add observable call thumbnail * chore: remove usage of `asStateFlow()`
…active call (#1614) * feature: reject call when busy * feature: write test cases for CallStateRingEvent and CallBusyHandler * fix: simplify logic * fix: simplify logic * fix: simplify logic and write unit tests * fix: set rejectCallWhenBusy to false in demo-app * fix: update kdoc * chore: update kdoc * chore: revert function visibility * chore: revert unnecessary changes * chore: refactor * chore: refactor * chore: Remove dependency of StreamVideoClient from CallBusyHandler * chore: update test cases * chore: use @InternalStreamVideoApi to hide rejectCallWhenBusy from public api * chore: refactor * chore: refactor --------- Co-authored-by: Aleksandar Apostolov <apostolov.alexandar@gmail.com>
* fix: Update ringing state on call-ended event * fix: Update ringing state on call-ended event * chore: refactor
…ng flow (#1617) * fix: Correctly update from RingingState.Outgoing is to RingingState.Active when we perform joinAndRing and WS is not connected To set WS connection to null set the return of waitForConnectionId to null * chore: refactor * chore: atomically update ringingStateUpdatesStopped * chore: refactor ringingLogger * chore: improve `joinAndRing` state management and ringing logic - Renamed `ringingStateUpdatesStopped` to `isJoinAndRingInProgress` in `CallState` for better clarity. - Updated `updateRingingState` to properly handle `RingingState.Active` transitions during normal joins vs. `joinAndRing` flows. - Modified `updateFromJoinResponse` to ensure `acceptedBy` list correctly merges server-side data with local state. - Refined `ClientState` transition logic to prevent premature call acceptance states when a `joinAndRing` operation is in progress. - Renamed `toggleRingingStateUpdates` to `toggleJoinAndRingProgress`. --------- Co-authored-by: Aleksandar Apostolov <apostolov.alexandar@gmail.com>
* fix: Re-apply mic-state on `TrackPublishedEvent` * fix: refactor * fix: correct the logic
Contributor
PR checklist ✅All required conditions are satisfied:
🎉 Great job! This PR is ready for review. |
WalkthroughThis pull request refactors model class names across the Stream Video Android SDK to improve clarity and domain specificity. Primary changes include renaming generic types like Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
📝 Coding Plan for PR comments
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (2)
stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/CallState.kt (1)
663-664: Consider keeping generated reaction models behind the SDK boundary.This rename is correct locally, but it also means every OpenAPI model rename now becomes SDK API churn. Exposing a stable domain reaction type here would avoid pushing generator-owned names through
CallState.reactions,Reaction.response, andCall.sendReaction()whenever the spec regenerates.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/CallState.kt` around lines 663 - 664, CallState currently exposes generator-owned model VideoReactionResponse via internal _reactions/val reactions which causes API churn when OpenAPI regenerates; introduce a stable SDK domain type (e.g., VideoReaction or ReactionModel) and change CallState._reactions and reactions to StateFlow<List<YourDomainReaction>>; map incoming VideoReactionResponse -> YourDomainReaction at the boundary where responses are parsed/received and map YourDomainReaction -> VideoReactionRequest (or the generator type) when calling Call.sendReaction(); update usages referencing Reaction.response to use the new domain type fields or provide conversion helpers so generator-owned names no longer leak through CallState.reactions, Reaction.response, and Call.sendReaction().stream-video-android-core/api/stream-video-android-core.api (1)
65-65: Ensure breaking changes are documented in release notes.This PR introduces several breaking API changes:
- Method:
sendReaction→sendVideoReaction- Types:
ReactionResponse→VideoReactionResponse,SendReactionRequest→SendVideoReactionRequest,SendReactionResponse→SendVideoReactionResponse- User event constructors significantly restructured
Consider documenting migration steps for SDK consumers upgrading to this version.
Also applies to: 6321-6321, 6337-6337, 8391-8391
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@stream-video-android-core/api/stream-video-android-core.api` at line 65, This PR introduces breaking API renames and constructor changes that must be documented in the release notes: list the method rename sendReaction → sendVideoReaction and the type renames ReactionResponse → VideoReactionResponse, SendReactionRequest → SendVideoReactionRequest, SendReactionResponse → SendVideoReactionResponse, and describe any changed user event constructors; provide concrete migration steps showing the old symbol and the new symbol for each renamed API (including example call patterns and any changed parameter order/semantics), note the versions affected, and add a compatibility section advising how consumers can update code (and any temporary shims/aliases if you provide them) so clients can upgrade safely. Ensure the release notes reference the exact symbols sendVideoReaction, sendReaction, VideoReactionResponse, ReactionResponse, SendVideoReactionRequest, SendReactionRequest, SendVideoReactionResponse, SendReactionResponse and clearly call out the user event constructor restructuring.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@stream-video-android-core/api/stream-video-android-core.api`:
- Line 65: This PR introduces breaking API renames and constructor changes that
must be documented in the release notes: list the method rename sendReaction →
sendVideoReaction and the type renames ReactionResponse → VideoReactionResponse,
SendReactionRequest → SendVideoReactionRequest, SendReactionResponse →
SendVideoReactionResponse, and describe any changed user event constructors;
provide concrete migration steps showing the old symbol and the new symbol for
each renamed API (including example call patterns and any changed parameter
order/semantics), note the versions affected, and add a compatibility section
advising how consumers can update code (and any temporary shims/aliases if you
provide them) so clients can upgrade safely. Ensure the release notes reference
the exact symbols sendVideoReaction, sendReaction, VideoReactionResponse,
ReactionResponse, SendVideoReactionRequest, SendReactionRequest,
SendVideoReactionResponse, SendReactionResponse and clearly call out the user
event constructor restructuring.
In
`@stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/CallState.kt`:
- Around line 663-664: CallState currently exposes generator-owned model
VideoReactionResponse via internal _reactions/val reactions which causes API
churn when OpenAPI regenerates; introduce a stable SDK domain type (e.g.,
VideoReaction or ReactionModel) and change CallState._reactions and reactions to
StateFlow<List<YourDomainReaction>>; map incoming VideoReactionResponse ->
YourDomainReaction at the boundary where responses are parsed/received and map
YourDomainReaction -> VideoReactionRequest (or the generator type) when calling
Call.sendReaction(); update usages referencing Reaction.response to use the new
domain type fields or provide conversion helpers so generator-owned names no
longer leak through CallState.reactions, Reaction.response, and
Call.sendReaction().
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: b92fd1c9-89ca-4850-832d-a93ba7d292cc
⛔ Files ignored due to path filters (32)
stream-video-android-core/src/main/kotlin/io/getstream/android/video/generated/apis/ProductvideoApi.ktis excluded by!**/generated/**stream-video-android-core/src/main/kotlin/io/getstream/android/video/generated/infrastructure/Serializer.ktis excluded by!**/generated/**stream-video-android-core/src/main/kotlin/io/getstream/android/video/generated/models/CallReactionEvent.ktis excluded by!**/generated/**stream-video-android-core/src/main/kotlin/io/getstream/android/video/generated/models/CallStatsReportReadyEvent.ktis excluded by!**/generated/**stream-video-android-core/src/main/kotlin/io/getstream/android/video/generated/models/CoordinatesResponse.ktis excluded by!**/generated/**stream-video-android-core/src/main/kotlin/io/getstream/android/video/generated/models/Credentials.ktis excluded by!**/generated/**stream-video-android-core/src/main/kotlin/io/getstream/android/video/generated/models/DeliveryReceipts.ktis excluded by!**/generated/**stream-video-android-core/src/main/kotlin/io/getstream/android/video/generated/models/ICEServerResponse.ktis excluded by!**/generated/**stream-video-android-core/src/main/kotlin/io/getstream/android/video/generated/models/IndividualRecordingSettingsRequest.ktis excluded by!**/generated/**stream-video-android-core/src/main/kotlin/io/getstream/android/video/generated/models/IndividualRecordingSettingsResponse.ktis excluded by!**/generated/**stream-video-android-core/src/main/kotlin/io/getstream/android/video/generated/models/JoinCallRequest.ktis excluded by!**/generated/**stream-video-android-core/src/main/kotlin/io/getstream/android/video/generated/models/LocationResponse.ktis excluded by!**/generated/**stream-video-android-core/src/main/kotlin/io/getstream/android/video/generated/models/PrivacySettings.ktis excluded by!**/generated/**stream-video-android-core/src/main/kotlin/io/getstream/android/video/generated/models/ResolveSipAuthRequest.ktis excluded by!**/generated/**stream-video-android-core/src/main/kotlin/io/getstream/android/video/generated/models/ResolveSipAuthResponse.ktis excluded by!**/generated/**stream-video-android-core/src/main/kotlin/io/getstream/android/video/generated/models/ResolveSipInboundRequest.ktis excluded by!**/generated/**stream-video-android-core/src/main/kotlin/io/getstream/android/video/generated/models/SFULocationResponse.ktis excluded by!**/generated/**stream-video-android-core/src/main/kotlin/io/getstream/android/video/generated/models/SIPChallengeRequest.ktis excluded by!**/generated/**stream-video-android-core/src/main/kotlin/io/getstream/android/video/generated/models/SendVideoReactionRequest.ktis excluded by!**/generated/**stream-video-android-core/src/main/kotlin/io/getstream/android/video/generated/models/SendVideoReactionResponse.ktis excluded by!**/generated/**stream-video-android-core/src/main/kotlin/io/getstream/android/video/generated/models/SipInboundCredentials.ktis excluded by!**/generated/**stream-video-android-core/src/main/kotlin/io/getstream/android/video/generated/models/SortParamRequest.ktis excluded by!**/generated/**stream-video-android-core/src/main/kotlin/io/getstream/android/video/generated/models/TypingIndicators.ktis excluded by!**/generated/**stream-video-android-core/src/main/kotlin/io/getstream/android/video/generated/models/UserBannedEvent.ktis excluded by!**/generated/**stream-video-android-core/src/main/kotlin/io/getstream/android/video/generated/models/UserDeactivatedEvent.ktis excluded by!**/generated/**stream-video-android-core/src/main/kotlin/io/getstream/android/video/generated/models/UserDeletedEvent.ktis excluded by!**/generated/**stream-video-android-core/src/main/kotlin/io/getstream/android/video/generated/models/UserPresenceChangedEvent.ktis excluded by!**/generated/**stream-video-android-core/src/main/kotlin/io/getstream/android/video/generated/models/UserReactivatedEvent.ktis excluded by!**/generated/**stream-video-android-core/src/main/kotlin/io/getstream/android/video/generated/models/UserResponseCommonFields.ktis excluded by!**/generated/**stream-video-android-core/src/main/kotlin/io/getstream/android/video/generated/models/UserUnbannedEvent.ktis excluded by!**/generated/**stream-video-android-core/src/main/kotlin/io/getstream/android/video/generated/models/VideoEvent.ktis excluded by!**/generated/**stream-video-android-core/src/main/kotlin/io/getstream/android/video/generated/models/VideoReactionResponse.ktis excluded by!**/generated/**
📒 Files selected for processing (7)
stream-video-android-core/api/stream-video-android-core.apistream-video-android-core/src/main/kotlin/io/getstream/video/android/core/Call.ktstream-video-android-core/src/main/kotlin/io/getstream/video/android/core/CallState.ktstream-video-android-core/src/main/kotlin/io/getstream/video/android/core/StreamVideoClient.ktstream-video-android-core/src/main/kotlin/io/getstream/video/android/core/model/IceServer.ktstream-video-android-core/src/main/kotlin/io/getstream/video/android/core/model/Reaction.ktstream-video-android-core/src/main/kotlin/io/getstream/video/android/core/utils/DomainUtils.kt
Contributor
SDK Size Comparison 📏
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Update open api models for Video
Implementation
Update open api models for Video
🎨 UI Changes
none
Testing
None
Summary by CodeRabbit