-
Notifications
You must be signed in to change notification settings - Fork 58
Improve Foreground Service orchestration when transitioning from outgoing call to active call #1627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
aleksandar-apostolov
merged 11 commits into
develop
from
bugfix/rahullohra/outgoing-call-fg-service-exception
Apr 1, 2026
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
bb74503
fix: 1. Fix Outgoing Call Service Exception 2. Create a permission Ui…
rahul-lohra 496b87b
chore: update notification
rahul-lohra 6cf4ad2
fix: Correctly invoke UI related methods from UI thread
rahul-lohra e8302b9
fix: refactor
rahul-lohra f1a1c65
fix: fix unit tests
rahul-lohra 236ec29
fix: include InternalStreamVideoApi in apiValidation
rahul-lohra 91426df
Merge branch 'develop' into bugfix/rahullohra/outgoing-call-fg-servic…
rahul-lohra 2039763
Merge branch 'develop' into bugfix/rahullohra/outgoing-call-fg-servic…
rahul-lohra accf57a
refactor: refactor code
rahul-lohra 13c5bdf
Merge branch 'develop' into bugfix/rahullohra/outgoing-call-fg-servic…
rahul-lohra 0bd6497
refactor: refactor code
rahul-lohra File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
41 changes: 41 additions & 0 deletions
41
...tream/video/android/core/notifications/internal/service/StreamForegroundPermissionUtil.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| /* | ||
| * Copyright (c) 2014-2026 Stream.io Inc. All rights reserved. | ||
| * | ||
| * Licensed under the Stream License; | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * https://github.com/GetStream/stream-video-android/blob/main/LICENSE | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package io.getstream.video.android.core.notifications.internal.service | ||
|
|
||
| import io.getstream.video.android.core.StreamVideo | ||
| import io.getstream.video.android.core.StreamVideoClient | ||
| import io.getstream.video.android.core.internal.InternalStreamVideoApi | ||
| import io.getstream.video.android.core.notifications.internal.service.permissions.AudioCallPermissionManager | ||
| import io.getstream.video.android.core.notifications.internal.service.permissions.ForegroundServicePermissionManager | ||
| import kotlin.jvm.java | ||
|
|
||
| @InternalStreamVideoApi | ||
| public object StreamForegroundPermissionUtil { | ||
|
|
||
| public fun getForegroundPermissionsForCallType(callType: String): Set<Int> { | ||
| val client = StreamVideo.instanceOrNull() as? StreamVideoClient | ||
| if (client != null) { | ||
| val config = client.callServiceConfigRegistry.get(callType) | ||
| return when (config.serviceClass) { | ||
| CallService::class.java -> ForegroundServicePermissionManager().requiredForegroundTypes | ||
| AudioCallService::class.java -> AudioCallPermissionManager().requiredForegroundTypes | ||
| else -> emptySet() | ||
| } | ||
| } | ||
|
aleksandar-apostolov marked this conversation as resolved.
|
||
| return emptySet() | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.