chore(ci): stop pushing release version bump to protected default branch#274
Merged
Conversation
The release workflow pushed the version-bump commit directly to the default branch, which is protected and rejects direct pushes (GH006). Commit the bump locally only and tag it; do not push to the default branch. Track release idempotency on the annotated release tag instead of a default-branch commit.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe release workflow now detects prior releases by searching annotated tag contents for PR markers. Version bump commits remain local for tagging, are not pushed to the protected default branch, and tags receive manual or PR-specific annotations. ChangesRelease workflow
Estimated code review effort: 3 (Moderate) | ~15–30 minutes Sequence Diagram(s)sequenceDiagram
participant GitHubEvent
participant ReleaseWorkflow
participant GitRepository
participant ReleaseTag
GitHubEvent->>ReleaseWorkflow: provide trigger type and PR number
ReleaseWorkflow->>GitRepository: search annotated tag contents
GitRepository-->>ReleaseWorkflow: return release marker result
ReleaseWorkflow->>GitRepository: commit version bump locally
ReleaseWorkflow->>ReleaseTag: create annotated tag
ReleaseTag-->>ReleaseWorkflow: store manual or PR-specific message
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The release job's version-bump step pushed the bump commit directly to the protected default branch and was rejected:
Versioning is already tag-driven —
bump_version.pyderives the previous version from the latest semver tag (find_latest_semver_tag), not frompyproject.toml— so the bump does not need to live on the default branch.Changes
Test plan
workflow_dispatch.Summary by CodeRabbit