feat: introduce Search component redesign#2981
Open
arnautov-anton wants to merge 2 commits intomasterfrom
Open
feat: introduce Search component redesign#2981arnautov-anton wants to merge 2 commits intomasterfrom
arnautov-anton wants to merge 2 commits intomasterfrom
Conversation
arnautov-anton
force-pushed
the
feat/search-redesign
branch
from
d67bcdd to
2229350
Compare
|
Size Change: +1.17 kB (+0.28%) Total Size: 418 kB
ℹ️ View Unchanged
|
arnautov-anton
force-pushed
the
feat/search-redesign
branch
from
fc9f052 to
b625580
Compare
MartinCupela
reviewed
Mar 7, 2026
| className='str-chat__channel-preview__action-buttons-context-menu' | ||
| dialogManagerId={dialogManager?.id} | ||
| id={dialog.id} | ||
| items={[ |
Contributor
There was a problem hiding this comment.
@arnautov-anton maybe for ChannelPreviewActionButtons we could use the same pattern as we used for MessageActions - have default structure defined + filter hook / logic + possibility to provide custom actions.
MartinCupela
reviewed
Mar 7, 2026
| new UserSearchSource(client), | ||
| new MessageSearchSource(client), | ||
| // new UserSearchSource(client), | ||
| // new MessageSearchSource(client), |
Contributor
There was a problem hiding this comment.
I would keep message search source because it is essentially search for channels by message text. In the preview text we would show the matching text by which the item was selected to the search results.
MartinCupela
reviewed
Mar 7, 2026
| <Button | ||
| appearance='outline' | ||
| circular | ||
| className='str-chat__search-input--clear-button' |
Contributor
There was a problem hiding this comment.
Suggested change
| className='str-chat__search-input--clear-button' | |
| className='str-chat__search-input__clear-button' |
MartinCupela
reviewed
Mar 7, 2026
| border-radius: var(--radius-max); | ||
| border: 1px solid var(--input-border-default); | ||
| color: var(--input-text-placeholder); | ||
| font-family: var(--typography-font-family-sans); |
Contributor
There was a problem hiding this comment.
I would use typography shorthand font: var(--str-chat__matching-font-text)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add minimal Search redesign.