feat: show uploading state when the attachments are uploaded in a pending state#3469
Open
feat: show uploading state when the attachments are uploaded in a pending state#3469
Conversation
…ed in a pending state
…ed in a pending state
Contributor
SDK Size
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for displaying a loading indicator when attachments (files, images, and videos) are being uploaded. The changes enhance user feedback during uploads by integrating loading indicators into the
FileAttachment,Gallery, andVideoThumbnailcomponents. The implementation leverages a centralized pending attachments loading state store to track upload status and conditionally render indicators.Attachment Upload Loading Indicator Integration
ImageUploadingIndicatorcomponent to show upload progress for images and integrated it intoGalleryandGalleryImageThumbnail. [1] [2]FileAttachmentandFileAttachmentWithContextto display anActivityIndicatorwhen a file is being uploaded, using the pending attachments loading state. [1] [2] [3] [4]VideoThumbnailto accept anisPendingAttachmentLoadingprop and render a loading indicator when a video attachment is uploading. [1] [2]State Management Enhancements
pendingAttachmentsLoadingStoreand selector logic intoFileAttachment,Gallery, andGalleryThumbnailto determine upload status for each attachment. [1] [2] [3] [4]Component API and Context Updates
Gallery,GalleryThumbnail, and related components to support new loading indicator functionality and pending attachments state. [1] [2] [3] [4] [5] [6] [7]Styling Improvements
FileAttachmentand ensured indicators are positioned correctly in image and video thumbnails. [1] [2]These changes collectively improve the user experience by providing clear visual feedback during attachment uploads, leveraging centralized state management for upload tracking, and extending component APIs to support this new functionality.