test(task-status): bump waitFor budget to 10 minutes#260
Open
nijeesh-stream wants to merge 1 commit into
Open
Conversation
#256 bumped TaskStatusTest > "Can get task status by id" from the default 5s to 5 minutes because the shared CI app's asynq queue is routinely backed up. The 5 minute budget is now also timing out under load — e.g. PR #259 build #26518080390 hit the cap while polling Channel.deleteMany's task to completion. Give the test another 5 minutes of headroom so a stuck queue still surfaces but healthy-but-slow runs stop failing. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Doubles the
waitForbudget inTaskStatusTest > Can get task status by idfrom 5 minutes to 10 minutes.The 5-minute budget was set in #256 because the shared CI app's asynq queue is routinely backed up. That budget is now also timing out — e.g. the latest CI run on PR #259 (build 26518080390) hit the cap while polling
Channel.deleteMany's task to completion:10 minutes still surfaces a genuinely stuck queue (waitFor will fail), but gives healthy-but-slow runs enough headroom to actually finish polling.
Test plan
./gradlew compileTestJava(JDK 11 toolchain)./gradlew spotlessCheckTaskStatusTest > Can get task status by idwithin the new budgetMade with Cursor