Skip to content

Remove redundant hardcoded sizes on Compose design icons #6478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andremion wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Remove redundant hardcoded sizes on Compose design icons #6478

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
253e911
refactor(compose): drop redundant 20dp hardcoded sizes on design icons
andremion May 27, 2026
ad3defb
refactor(compose): drop redundant 20dp sizes on poll icons
andremion May 27, 2026
f0be7dd
refactor(compose): drop redundant 20dp sizes in media gallery preview
andremion May 27, 2026
6b3e7fe
refactor(compose): drop redundant 20dp sizes in ContextualMenuItem
andremion May 27, 2026
10aba18
refactor(compose): drop redundant 20dp size on MessageFailedIcon
andremion May 27, 2026
5db9a0f
Merge branch 'develop' into refactor/remove-redundant-icon-sizes
andremion May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .../io/getstream/chat/android/compose/ui/attachments/content/AudioRecordAttachmentContent.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,6 @@ internal fun PlaybackToggleButton(
) {
Icon(
painter = icon,
modifier = Modifier.size(20.dp),
contentDescription = label,
)
}
Expand Down
3 changes: 0 additions & 3 deletions .../io/getstream/chat/android/compose/ui/attachments/content/UnsupportedAttachmentContent.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ import androidx.compose.foundation.layout.Column
import androidx.compose.foundation.layout.Row
import androidx.compose.foundation.layout.fillMaxWidth
import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.layout.size
import androidx.compose.foundation.shape.RoundedCornerShape
import androidx.compose.material3.Icon
import androidx.compose.material3.Text
Expand All @@ -32,7 +31,6 @@ import androidx.compose.ui.res.painterResource
import androidx.compose.ui.res.stringResource
import androidx.compose.ui.text.style.TextOverflow
import androidx.compose.ui.tooling.preview.Preview
import androidx.compose.ui.unit.dp
import io.getstream.chat.android.compose.R
import io.getstream.chat.android.compose.state.messages.attachments.AttachmentState
import io.getstream.chat.android.compose.ui.theme.ChatTheme
Expand Down Expand Up @@ -80,7 +78,6 @@ public fun UnsupportedAttachmentContent(
painter = painterResource(R.drawable.stream_design_ic_unsupported_attachment),
tint = ChatTheme.colors.textPrimary,
contentDescription = null,
modifier = Modifier.size(20.dp),
)

Text(
Expand Down
3 changes: 0 additions & 3 deletions ...o/getstream/chat/android/compose/ui/attachments/preview/MediaGalleryPreviewOptionsMenu.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ import androidx.compose.foundation.layout.Row
import androidx.compose.foundation.layout.Spacer
import androidx.compose.foundation.layout.fillMaxWidth
import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.layout.size
import androidx.compose.foundation.layout.width
import androidx.compose.material3.ExperimentalMaterial3Api
import androidx.compose.material3.Icon
Expand All @@ -37,7 +36,6 @@ import androidx.compose.ui.Modifier
import androidx.compose.ui.res.painterResource
import androidx.compose.ui.res.stringResource
import androidx.compose.ui.text.style.TextOverflow
import androidx.compose.ui.unit.dp
import io.getstream.chat.android.compose.R
import io.getstream.chat.android.compose.state.mediagallerypreview.Delete
import io.getstream.chat.android.compose.state.mediagallerypreview.MediaGalleryPreviewOption
Expand Down Expand Up @@ -132,7 +130,6 @@ internal fun MediaGalleryOptionItem(
verticalAlignment = Alignment.CenterVertically,
) {
Icon(
modifier = Modifier.size(20.dp),
painter = option.iconPainter,
tint = option.iconColor,
contentDescription = option.title,
Expand Down
2 changes: 0 additions & 2 deletions ...ava/io/getstream/chat/android/compose/ui/attachments/preview/MediaGalleryPreviewScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -873,7 +873,6 @@ internal fun MediaGalleryPreviewShareIcon(
Icon(
painter = painterResource(id = painter),
contentDescription = stringResource(id = description),
modifier = Modifier.size(20.dp),
)
}
}
Expand Down Expand Up @@ -949,7 +948,6 @@ internal fun MediaGalleryPreviewPhotosIcon(
Icon(
painter = painterResource(id = R.drawable.stream_design_ic_gallery),
contentDescription = stringResource(id = R.string.stream_compose_image_preview_photos),
modifier = Modifier.size(20.dp),
)
}
}
Expand Down
1 change: 0 additions & 1 deletion ...o/getstream/chat/android/compose/ui/attachments/preview/internal/VideoPlaybackControls.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,6 @@ internal fun VideoPlaybackControls(
Icon(
painter = painterResource(icon),
contentDescription = stringResource(contentDescription),
modifier = Modifier.size(20.dp),
)
}

Expand Down
1 change: 0 additions & 1 deletion ...mpose/src/main/java/io/getstream/chat/android/compose/ui/channel/info/AddMembersScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,6 @@ private fun AddMembersHeader(
style = StreamButtonStyleDefaults.secondaryGhost,
) {
Icon(
modifier = Modifier.size(20.dp),
painter = painterResource(id = R.drawable.stream_design_ic_arrow_left),
contentDescription = stringResource(id = UiCommonR.string.stream_ui_back_button),
)
Expand Down
2 changes: 0 additions & 2 deletions ...mpose/src/main/java/io/getstream/chat/android/compose/ui/components/ComposerCancelIcon.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ package io.getstream.chat.android.compose.ui.components
import androidx.compose.foundation.background
import androidx.compose.foundation.border
import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.layout.size
import androidx.compose.foundation.shape.CircleShape
import androidx.compose.material3.Icon
import androidx.compose.runtime.Composable
Expand Down Expand Up @@ -52,7 +51,6 @@ public fun ComposerCancelIcon(
.border(2.dp, colors.controlRemoveBorder, CircleShape)
.padding(2.dp)
.background(color = colors.controlRemoveBg, shape = CircleShape)
.size(20.dp)
.clickable(bounded = false, onClick = onClick),
painter = painterResource(R.drawable.stream_design_ic_xmark_small),
contentDescription = contentDescription,
Expand Down
3 changes: 0 additions & 3 deletions ...se/src/main/java/io/getstream/chat/android/compose/ui/components/common/ContextualMenu.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ import androidx.compose.foundation.layout.Row
import androidx.compose.foundation.layout.defaultMinSize
import androidx.compose.foundation.layout.fillMaxWidth
import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.layout.size
import androidx.compose.foundation.layout.width
import androidx.compose.foundation.shape.RoundedCornerShape
import androidx.compose.material3.HorizontalDivider
Expand Down Expand Up @@ -96,7 +95,6 @@ internal fun ContextualMenuItem(
painter = it,
contentDescription = null,
tint = iconColor,
modifier = Modifier.size(20.dp),
)
}

Expand All @@ -114,7 +112,6 @@ internal fun ContextualMenuItem(
painter = it,
contentDescription = null,
tint = iconColor,
modifier = Modifier.size(20.dp),
)
}
}
Expand Down
1 change: 0 additions & 1 deletion .../main/java/io/getstream/chat/android/compose/ui/components/messages/PollMessageContent.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,6 @@ public fun PollMessageContent(
params = MessageFailedIconParams(
modifier = Modifier
.padding(vertical = StreamTokens.spacingXs)
.size(20.dp)
.align(Alignment.TopEnd),
message = message,
),
Expand Down
2 changes: 0 additions & 2 deletions ...compose/src/main/java/io/getstream/chat/android/compose/ui/components/poll/PollAnswers.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ import androidx.compose.ui.focus.focusRequester
import androidx.compose.ui.res.painterResource
import androidx.compose.ui.res.stringResource
import androidx.compose.ui.tooling.preview.Preview
import androidx.compose.ui.unit.dp
import androidx.compose.ui.window.Popup
import io.getstream.chat.android.compose.R
import io.getstream.chat.android.compose.ui.components.avatar.AvatarSize
Expand Down Expand Up @@ -155,7 +154,6 @@ private fun Content(
Icon(
painter = painterResource(id = R.drawable.stream_design_ic_edit),
contentDescription = stringResource(id = R.string.stream_compose_add_answer),
modifier = Modifier.size(20.dp),
)
}
}
Expand Down
3 changes: 0 additions & 3 deletions ...ain/java/io/getstream/chat/android/compose/ui/messages/attachments/poll/PollOptionList.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ import androidx.compose.foundation.layout.Row
import androidx.compose.foundation.layout.defaultMinSize
import androidx.compose.foundation.layout.fillMaxWidth
import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.layout.size
import androidx.compose.foundation.shape.RoundedCornerShape
import androidx.compose.material3.Icon
import androidx.compose.material3.IconButton
Expand Down Expand Up @@ -187,7 +186,6 @@ private fun ReorderableScope.PollOptionRow(
painter = painterResource(R.drawable.stream_design_ic_minus_circle),
contentDescription = stringResource(R.string.stream_compose_poll_option_remove, displayName),
tint = colors.inputTextIcon,
modifier = Modifier.size(20.dp),
)
}
}
Expand Down Expand Up @@ -217,7 +215,6 @@ private fun PollOptionErrorRow(pollOptionError: PollOptionError) {
painter = painterResource(R.drawable.stream_design_ic_exclamation_circle),
contentDescription = null,
tint = colors.accentError,
modifier = Modifier.size(20.dp),
)
Text(
text = pollOptionError.message,
Expand Down
1 change: 0 additions & 1 deletion ...ain/java/io/getstream/chat/android/compose/ui/messages/attachments/poll/PollSwitchList.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,7 +339,6 @@ private fun StepperButton(
contentAlignment = Alignment.Center,
) {
Icon(
modifier = Modifier.size(20.dp),
painter = painterResource(id = iconRes),
contentDescription = contentDescription,
tint = if (enabled) ChatTheme.colors.buttonSecondaryText else ChatTheme.colors.textDisabled,
Expand Down
2 changes: 0 additions & 2 deletions ...pose/src/main/java/io/getstream/chat/android/compose/ui/messages/list/MessageContainer.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -705,7 +705,6 @@ public fun EmojiMessageContent(
params = MessageFailedIconParams(
modifier = Modifier
.padding(vertical = StreamTokens.spacingXs)
.size(20.dp)
.align(Alignment.TopEnd),
message = message,
),
Expand Down Expand Up @@ -782,7 +781,6 @@ public fun RegularMessageContent(
params = MessageFailedIconParams(
modifier = Modifier
.padding(vertical = StreamTokens.spacingXs)
.size(20.dp)
.align(Alignment.TopEnd)
.testTag("Stream_MessageFailedIcon"),
message = message,
Expand Down
Loading