Conversation
Contributor
|
tried rendering a simple element with the token, after rebuilding tokens vs master looks much better! |
ZakaryH
approved these changes
Feb 12, 2026
Contributor
ZakaryH
left a comment
ZakaryH
left a comment
There was a problem hiding this comment.
LGTM apologies for the delay!
ZakaryH
deleted the
CLEANUP/add-missing-dark-mode-token--color-surface--background--subtle--hover
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were lacking a token for
color-surface--background--subtle--hoverfor dark mode and it was falling back to the light token. This adds a dark token.Changes
Added
color-surface--background--subtle--hoverToken for dark modeTesting
Changes can be
tested via Pre-release
In Atlantis we use Github's built in pull request reviews.