Conversation
dafeder
requested changes
Dec 2, 2020
| { | ||
| $notSmart = new JsonObject("{$this->data}"); | ||
| return $notSmart->get($name) ? true : false; | ||
| $thing = $notSmart->get($name); |
Member
There was a problem hiding this comment.
Let's avoid variable names this unnecessarily vague - can we call this $value or $result? Aside from that though, I'm not sure why this is an improvement? When not using smartget, we should always get either an array or false, so I'm not clear on what edge case we're addressing here.
| @@ -146,9 +146,17 @@ public function __set($path, $value) | |||
| public function __isset($name) | |||
Member
There was a problem hiding this comment.
Oh my bad, that's from my pull request! I guess I should add that in a separate PR
| public function __unset($name) | ||
| { | ||
| $field = str_replace('$.', '', $name); | ||
| $this->data->remove('$', $field); |
Member
There was a problem hiding this comment.
Would this work one or more levels down?
| return ($thing === false) ? false : true; | ||
| } | ||
|
|
||
| public function __unset($name) |
Member
There was a problem hiding this comment.
Seems like both here and in my __isset() method $path would be a more appropriate name than $name, doesn't it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.